Sign upLogin

18F/acqstackdb

View on GitHub
Star

Showing 10 of 10 total issues

File models.py has 288 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from django.db import models
from django.core.validators import RegexValidator, ValidationError
from django.utils.translation import ugettext_lazy as _
from django.contrib.auth.models import User
from smart_selects.db_fields import ChainedForeignKey, ChainedManyToManyField
Severity: Minor
Found in acquisitions/models.py - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    @pytest.mark.django_db
def test_create_vendor():
    vendor = Vendor.objects.create(
        name="Test Vendor",
        email="testvendor@fake.biz",
    Severity: Major
    Found in acquisitions/tests/test_models.py and 1 other location - About 1 hr to fix
    acquisitions/tests/test_models.py on lines 78..86

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 42.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        with pytest.raises(ValidationError):
        bad_duns_vendor = Vendor.objects.create(
            name="Bad DUNS Vendor",
            email="testvendor@fake.biz",
            duns=666
    Severity: Major
    Found in acquisitions/tests/test_models.py and 1 other location - About 1 hr to fix
    acquisitions/tests/test_models.py on lines 64..73

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 42.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function home has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    def home(request):
    acquisitions = Acquisition.objects.all()
    tracks = Track.objects.all()
    stages = Stage.objects.all()
    steps = Step.objects.all()
    Severity: Minor
    Found in acquisitions/views.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Invalid escape sequence '\d'
    Open

            RegexValidator(regex='^\d{9}$', message="DUNS number must be 9 digits")
    Severity: Minor
    Found in acquisitions/models.py by pep8

    Invalid escape sequences are deprecated in Python 3.6.

    Okay: regex = r'\.png$'
W605: regex = '\.png$'

    Do not use bare 'except'
    Open

        except:
    Severity: Minor
    Found in acquisitions/views.py by pep8

    When catching exceptions, mention specific exceptions when possible.

    Okay: except Exception:
Okay: except BaseException:
E722: except:

    Rule doesn't have all its properties in alphabetical order.
    Open

    .stages-form > button[type="submit"], h2 {
    Severity: Minor
    Found in acquisitions/static/acquisitions/css/style.css by csslint

    Rule doesn't have all its properties in alphabetical order.
    Open

    .table-link {
    Severity: Minor
    Found in acquisitions/static/acquisitions/css/style.css by csslint

    Module level import not at top of file
    Open

    from whitenoise.django import DjangoWhiteNoise
    Severity: Minor
    Found in acqstackdb/wsgi.py by pep8

    Place imports at the top of the file.

    Always put imports at the top of the file, just after any module
comments and docstrings, and before module globals and constants.

Okay: import os
Okay: # this is a comment\nimport os
Okay: '''this is a module docstring'''\nimport os
Okay: r'''this is a module docstring'''\nimport os
Okay:
try:\n\timport x\nexcept ImportError:\n\tpass\nelse:\n\tpass\nimport y
Okay:
try:\n\timport x\nexcept ImportError:\n\tpass\nfinally:\n\tpass\nimport y
E402: a=1\nimport os
E402: 'One string'\n"Two string"\nimport os
E402: a=1\nfrom sys import x

Okay: if x:\n    import os

    Expected 2 blank lines after class or function definition, found 1
    Open

    admin.site.register(Stage, StageAdmin)
    Severity: Minor
    Found in acquisitions/admin.py by pep8

    Separate top-level function and class definitions with two blank lines.

    Method definitions inside a class are separated by a single blank
line.

Extra blank lines may be used (sparingly) to separate groups of
related functions.  Blank lines may be omitted between a bunch of
related one-liners (e.g. a set of dummy implementations).

Use blank lines in functions, sparingly, to indicate logical
sections.

Okay: def a():\n    pass\n\n\ndef b():\n    pass
Okay: def a():\n    pass\n\n\nasync def b():\n    pass
Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
Okay: default = 1\nfoo = 1
Okay: classify = 1\nfoo = 1

E301: class Foo:\n    b = 0\n    def bar():\n        pass
E302: def a():\n    pass\n\ndef b(n):\n    pass
E302: def a():\n    pass\n\nasync def b(n):\n    pass
E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
E303: def a():\n\n\n\n    pass
E304: @decorator\n\ndef a():\n    pass
E305: def a():\n    pass\na()
E306: def a():\n    def b():\n        pass\n    def c():\n        pass
    Severity
    Category
    Status
    Source
    Language