data_capture/views/price_list_upload.py

Summary

Maintainability
C
1 day
Test Coverage
A
100%

File price_list_upload.py has 295 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import json

from django.views.decorators.http import require_http_methods
from django.shortcuts import redirect, render
from django.template.loader import render_to_string
Severity: Minor
Found in data_capture/views/price_list_upload.py - About 3 hrs to fix

    Function step_4 has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    def step_4(request, step):
        gleaned_data = get_deserialized_gleaned_data(request)
    
        if gleaned_data is None:
            return redirect('data_capture:step_3')
    Severity: Minor
    Found in data_capture/views/price_list_upload.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function step_3 has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    def step_3(request, step, recorder):
        if get_step_form_from_session(2, request) is None:
            return redirect('data_capture:step_2')
    
        session_pl = request.session[SESSION_KEY]
    Severity: Minor
    Found in data_capture/views/price_list_upload.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function step_1 has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    def step_1(request, step):
        if request.method == 'GET':
            form = forms.Step1Form(data=get_nested_item(
                request.session,
                (SESSION_KEY, 'step_1_POST')
    Severity: Minor
    Found in data_capture/views/price_list_upload.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function step_2 has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def step_2(request, step):
        # Redirect back to step 1 if we don't have data
        if get_step_form_from_session(1, request) is None:
            return redirect('data_capture:step_1')
        else:
    Severity: Minor
    Found in data_capture/views/price_list_upload.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

        return step.render(request, {
    Severity: Major
    Found in data_capture/views/price_list_upload.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return redirect('data_capture:step_5')
      Severity: Major
      Found in data_capture/views/price_list_upload.py - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        @steps.step(label='Data verification')
        @login_required
        @permission_required(PRICE_LIST_UPLOAD_PERMISSION, raise_exception=True)
        @require_http_methods(["GET", "POST"])
        @handle_cancel
        Severity: Minor
        Found in data_capture/views/price_list_upload.py and 1 other location - About 30 mins to fix
        data_capture/views/price_list_upload.py on lines 171..176

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        @steps.step(label='Price list upload')
        @login_required
        @permission_required(PRICE_LIST_UPLOAD_PERMISSION, raise_exception=True)
        @require_http_methods(["GET", "POST"])
        @handle_cancel
        Severity: Minor
        Found in data_capture/views/price_list_upload.py and 1 other location - About 30 mins to fix
        data_capture/views/price_list_upload.py on lines 266..271

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status