Sign upLogin

18F/calc

View on GitHub
Star

Showing 176 of 177 total issues

Identical blocks of code found in 6 locations. Consider refactoring.
Open

def glean_labor_categories_from_file(f, sheet_name=DEFAULT_SHEET_NAME):
    book = xlrd.open_workbook(file_contents=f.read())
    return glean_labor_categories_from_book(book, sheet_name)
Severity: Major
Found in data_capture/schedules/s03fac.py and 5 other locations - About 40 mins to fix
data_capture/schedules/mas_consolidated.py on lines 82..84
data_capture/schedules/region_10.py on lines 71..73
data_capture/schedules/region_3.py on lines 61..63
data_capture/schedules/s70.py on lines 101..114
data_capture/schedules/s736.py on lines 126..128

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function send_mail has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def send_mail(subject, to, template, ctx, reply_to=None):
Severity: Minor
Found in data_capture/email.py - About 35 mins to fix

    Function broaden_query has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def broaden_query(cursor, vocab, query, cache, min_count):
    Severity: Minor
    Found in data_capture/analysis/vocabulary.py - About 35 mins to fix

      Function get_best_permutations has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def get_best_permutations(vocab, lexemes, min_count=1, min_length=4,
      Severity: Minor
      Found in data_capture/analysis/vocabulary.py - About 35 mins to fix

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

        BusinessSize.propTypes = {
  size: PropTypes.string.isRequired,
  setSize: PropTypes.func.isRequired,
  idPrefix: PropTypes.string,
};
        Severity: Major
        Found in frontend/source/js/data-explorer/components/business-size.jsx and 4 other locations - About 35 mins to fix
        frontend/source/js/data-explorer/components/contract-year.jsx on lines 100..104
        frontend/source/js/data-explorer/components/proposed-price.jsx on lines 104..108
        frontend/source/js/data-explorer/components/query-type.jsx on lines 46..50
        frontend/source/js/data-explorer/components/site.jsx on lines 32..36

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          if (site) {
    filters.push(
      <DescriptionFilter key="sit" label="worksite">
        {SITE_LABELS[site]}
      </DescriptionFilter>,
        Severity: Minor
        Found in frontend/source/js/data-explorer/components/description.jsx and 2 other locations - About 35 mins to fix
        frontend/source/js/data-explorer/components/description.jsx on lines 77..83
        frontend/source/js/data-explorer/components/description.jsx on lines 85..91

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

        ProposedPrice.propTypes = {
  proposedPrice: PropTypes.number.isRequired,
  setProposedPrice: PropTypes.func.isRequired,
  idPrefix: PropTypes.string,
};
        Severity: Major
        Found in frontend/source/js/data-explorer/components/proposed-price.jsx and 4 other locations - About 35 mins to fix
        frontend/source/js/data-explorer/components/business-size.jsx on lines 32..36
        frontend/source/js/data-explorer/components/contract-year.jsx on lines 100..104
        frontend/source/js/data-explorer/components/query-type.jsx on lines 46..50
        frontend/source/js/data-explorer/components/site.jsx on lines 32..36

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          if (schedule) {
    filters.push(
      <DescriptionFilter key="sch" label="schedule">
        {scheduleLabels[schedule]}
      </DescriptionFilter>,
        Severity: Minor
        Found in frontend/source/js/data-explorer/components/description.jsx and 2 other locations - About 35 mins to fix
        frontend/source/js/data-explorer/components/description.jsx on lines 69..75
        frontend/source/js/data-explorer/components/description.jsx on lines 77..83

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          if (businessSize) {
    filters.push(
      <DescriptionFilter key="bus" label="business size">
        {BUSINESS_SIZE_LABELS[businessSize]}
      </DescriptionFilter>,
        Severity: Minor
        Found in frontend/source/js/data-explorer/components/description.jsx and 2 other locations - About 35 mins to fix
        frontend/source/js/data-explorer/components/description.jsx on lines 69..75
        frontend/source/js/data-explorer/components/description.jsx on lines 85..91

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

        Site.propTypes = {
  site: PropTypes.string.isRequired,
  setSite: PropTypes.func.isRequired,
  idPrefix: PropTypes.string,
};
        Severity: Major
        Found in frontend/source/js/data-explorer/components/site.jsx and 4 other locations - About 35 mins to fix
        frontend/source/js/data-explorer/components/business-size.jsx on lines 32..36
        frontend/source/js/data-explorer/components/contract-year.jsx on lines 100..104
        frontend/source/js/data-explorer/components/proposed-price.jsx on lines 104..108
        frontend/source/js/data-explorer/components/query-type.jsx on lines 46..50

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

        QueryType.propTypes = {
  queryType: PropTypes.string.isRequired,
  setQueryType: PropTypes.func.isRequired,
  idPrefix: PropTypes.string,
};
        Severity: Major
        Found in frontend/source/js/data-explorer/components/query-type.jsx and 4 other locations - About 35 mins to fix
        frontend/source/js/data-explorer/components/business-size.jsx on lines 32..36
        frontend/source/js/data-explorer/components/contract-year.jsx on lines 100..104
        frontend/source/js/data-explorer/components/proposed-price.jsx on lines 104..108
        frontend/source/js/data-explorer/components/site.jsx on lines 32..36

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

        ContractYear.propTypes = {
  contractYear: PropTypes.string.isRequired,
  setContractYear: PropTypes.func.isRequired,
  idPrefix: PropTypes.string,
};
        Severity: Major
        Found in frontend/source/js/data-explorer/components/contract-year.jsx and 4 other locations - About 35 mins to fix
        frontend/source/js/data-explorer/components/business-size.jsx on lines 32..36
        frontend/source/js/data-explorer/components/proposed-price.jsx on lines 104..108
        frontend/source/js/data-explorer/components/query-type.jsx on lines 46..50
        frontend/source/js/data-explorer/components/site.jsx on lines 32..36

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function attachedCallback has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          attachedCallback() {
    if ('isUpgraded' in this) {
      // We've already been attached.
      return;
    }
        Severity: Minor
        Found in frontend/source/js/data-capture/expandable-area.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getCustomMessage has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        export function getCustomMessage(type, validity) {
  if (validity.typeMismatch) {
    return ERROR_MESSAGES[`${type}Mismatch`];
  } else {
    for (const invalidKey in ERROR_MESSAGES) { // eslint-disable-line no-restricted-syntax
        Severity: Minor
        Found in frontend/source/js/data-capture/form-validation.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function glean_labor_categories_from_book has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        def glean_labor_categories_from_book(book, sheet_name=DEFAULT_SHEET_NAME):
    # TODO: This should be DRY'd out a bit since it is extremely similar
    # to the s70.py function of the same name.

    if sheet_name not in book.sheet_names():
        Severity: Minor
        Found in data_capture/schedules/s03fac.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _create_contract_batches has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        def _create_contract_batches(upload_source, batch_size=5000, rows=None):
    if rows is None:
        r10_file = ContentFile(upload_source.original_file)
        converter = Region10SpreadsheetConverter(r10_file)
        rows = converter.convert_next()
        Severity: Minor
        Found in data_capture/jobs.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function update_price_fields has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def update_price_fields(self):
        '''
        Set current, next, and second year price fields based on this
        contract's contract_year.
        '''
        Severity: Minor
        Found in contracts/models.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function command has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        def command(user_file, groupname, dryrun):
    '''
    Bulk creates users from email addresses in the the specified text file,
    which should contain one email address per line.
    If the optional "--group <GROUPNAME>" argument is specified, then all the
        Severity: Minor
        Found in meta/management/commands/bulkcreateusers.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function glean_labor_categories_from_book has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        def glean_labor_categories_from_book(book, sheet_name=DEFAULT_SHEET_NAME):

    if sheet_name not in book.sheet_names():
        raise ValidationError(
            'There is no sheet in the workbook called "%s".' % sheet_name
        Severity: Minor
        Found in data_capture/schedules/region_3.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function glean_labor_categories_from_book has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        def glean_labor_categories_from_book(book, sheet_name=DEFAULT_SHEET_NAME):
    # TODO: This should be DRY'd out a bit since it is extremely similar
    # to the s70.py function of the same name.

    if sheet_name not in book.sheet_names():
        Severity: Minor
        Found in data_capture/schedules/region_10.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language