Sign upLogin

18F/cg-dashboard

View on GitHub
Star
helpers/testhelpers/testhelpers.go

Summary

Maintainability
B
4 hrs
Test Coverage

Function CreateExternalServerForPrivileged has a Cognitive Complexity of 36 (exceeds 20 allowed). Consider refactoring.
Open

func CreateExternalServerForPrivileged(t *testing.T, test BasicProxyTest) *httptest.Server {
    return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
        privilegedToken := "90d64460d14870c08c81352a05dedd3465940a7c"
        if r.URL.String() == "/oauth/token" {
Severity: Minor
Found in helpers/testhelpers/testhelpers.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function PrepareExternalServerCall has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

func PrepareExternalServerCall(t *testing.T, c *controllers.SecureContext, testServer *httptest.Server, fullURL string, test BasicProxyTest) (*httptest.ResponseRecorder, *http.Request, *web.Router) {
Severity: Minor
Found in helpers/testhelpers/testhelpers.go - About 35 mins to fix

    Function CreateExternalServer has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
    Open

    func CreateExternalServer(t *testing.T, test *BasicProxyTest) *httptest.Server {
    return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
        foundHandler := false
        for _, handler := range test.Handlers {
            if r.URL.RequestURI() == handler.ExpectedPath && r.Method == handler.RequestMethod {
    Severity: Minor
    Found in helpers/testhelpers/testhelpers.go - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status