18F/cg-sandbox-bot

View on GitHub

Showing 216 of 216 total issues

Class has too many lines. [145/100]
Open

class CFClient

  @@domain_name = ENV["DOMAIN_NAME"]

    def initialize(client_id, client_secret, uaa_url)
Severity: Minor
Found in cf_client.rb by rubocop

This cop checks if the length a class exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for process_new_users is too high. [71.2/15]
Open

def process_new_users

  last_user_date = nil
    users = @cf_client.get_users

Severity: Minor
Found in monitor.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [62/10]
Open

def process_new_users

  last_user_date = nil
    users = @cf_client.get_users

Severity: Minor
Found in monitor.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method process_new_users has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

def process_new_users

  last_user_date = nil
    users = @cf_client.get_users

Severity: Minor
Found in monitor.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Assignment Branch Condition size for increase_org_quota is too high. [30.23/15]
Open

  def increase_org_quota(org)

    quota = get_organization_quota(org['entity']['quota_definition_guid'])
    update_url = quota["metadata"]["url"]
    quota_total_routes = quota["entity"]["total_routes"]
Severity: Minor
Found in cf_client.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Block has too many lines. [57/25]
Open

  users.each do |user|

    is_new_org = false

    # save the date of the most recent user added
Severity: Minor
Found in monitor.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Perceived complexity for process_new_users is too high. [18/7]
Open

def process_new_users

  last_user_date = nil
    users = @cf_client.get_users

Severity: Minor
Found in monitor.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Cyclomatic complexity for process_new_users is too high. [17/6]
Open

def process_new_users

  last_user_date = nil
    users = @cf_client.get_users

Severity: Minor
Found in monitor.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method has too many lines. [19/10]
Open

  def increase_org_quota(org)

    quota = get_organization_quota(org['entity']['quota_definition_guid'])
    update_url = quota["metadata"]["url"]
    quota_total_routes = quota["entity"]["total_routes"]
Severity: Minor
Found in cf_client.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method process_new_users has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def process_new_users

  last_user_date = nil
    users = @cf_client.get_users

Severity: Major
Found in monitor.rb - About 2 hrs to fix

    Method has too many lines. [11/10]
    Open

      def get_organization_space_quota_definition_by_name(org_guid, name)
    
        space_quota_definition = nil
    
        space_quota_definitions = get_organization_space_quota_definitions(org_guid)
    Severity: Minor
    Found in cf_client.rb by rubocop

    This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

    Method has too many lines. [11/10]
    Open

      def create_organization_space_quota_definition(org_guid, space_name)
    
        req = {
          organization_guid: org_guid,
          name: space_name,
    Severity: Minor
    Found in cf_client.rb by rubocop

    This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

    Method create_space has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def create_space(name, organization_guid, developer_guids, manager_guids, space_quota_guid)
    Severity: Minor
    Found in cf_client.rb - About 35 mins to fix

      Method increase_org_quota has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def increase_org_quota(org)
      
          quota = get_organization_quota(org['entity']['quota_definition_guid'])
          update_url = quota["metadata"]["url"]
          quota_total_routes = quota["entity"]["total_routes"]
      Severity: Minor
      Found in cf_client.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Use empty lines between method definitions.
      Open

        def create_organization(org_name, quota_definition_guid)
      Severity: Minor
      Found in cf_client.rb by rubocop

      This cop checks whether method definitions are separated by one empty line.

      NumberOfEmptyLines can be and integer (e.g. 1 by default) or an array (e.g. [1, 2]) to specificy a minimum and a maximum of empty lines.

      AllowAdjacentOneLineDefs can be used to configure is adjacent one line methods definitions are an offense

      Example:

      # bad
      def a
      end
      def b
      end

      Example:

      # good
      def a
      end
      
      def b
      end

      Extra blank line detected.
      Open

      
        def create_organization(org_name, quota_definition_guid)
      Severity: Minor
      Found in cf_client.rb by rubocop

      This cops checks for two or more consecutive blank lines.

      Example:

      # bad - It has two empty lines.
      some_method
      # one empty line
      # two empty lines
      some_method
      
      # good
      some_method
      # one empty line
      some_method

      Useless assignment to variable - org.
      Open

          org = response.parsed
      Severity: Minor
      Found in cf_client.rb by rubocop

      This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

      assigned but unused variable - foo

      Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

      Example:

      # bad
      
      def some_method
        some_var = 1
        do_something
      end

      Example:

      # good
      
      def some_method
        some_var = 1
        do_something(some_var)
      end

      Redundant return detected.
      Open

          return quota
      Severity: Minor
      Found in cf_client.rb by rubocop

      This cop checks for redundant return expressions.

      Example:

      def test
        return something
      end
      
      def test
        one
        two
        three
        return something
      end

      It should be extended to handle methods whose body is if/else or a case expression with a default branch.

      Prefer single-quoted strings when you don't need string interpolation or special symbols.
      Open

          quota_total_routes = quota["entity"]["total_routes"]
      Severity: Minor
      Found in cf_client.rb by rubocop

      Checks if uses of quotes match the configured preference.

      Example: EnforcedStyle: single_quotes (default)

      # bad
      "No special symbols"
      "No string interpolation"
      "Just text"
      
      # good
      'No special symbols'
      'No string interpolation'
      'Just text'
      "Wait! What's #{this}!"

      Example: EnforcedStyle: double_quotes

      # bad
      'Just some text'
      'No special chars or interpolation'
      
      # good
      "Just some text"
      "No special chars or interpolation"
      "Every string in #{project} uses double_quotes"

      Align the parameters of a method call if they span more than one line.
      Open

                [user["metadata"]["guid"]], [user["metadata"]["guid"]],
      Severity: Minor
      Found in monitor.rb by rubocop

      Here we check if the parameters on a multi-line method call or definition are aligned.

      Example: EnforcedStyle: withfirstparameter (default)

      # good
      
      foo :bar,
          :baz
      
      # bad
      
      foo :bar,
        :baz

      Example: EnforcedStyle: withfixedindentation

      # good
      
      foo :bar,
        :baz
      
      # bad
      
      foo :bar,
          :baz
      Severity
      Category
      Status
      Source
      Language