Sign upLogin

18F/dolores-landingham-slack-bot

View on GitHub
Star
db/migrate/20151006161911_add_missing_unique_indices.acts_as_taggable_on_engine.rb

Summary

Maintainability
A
0 mins
Test Coverage

Use %i or %I for an array of symbols.
Open

              [:tag_id, :taggable_id, :taggable_type, :context, :tagger_id, :tagger_type],
Severity: Minor
Found in db/migrate/20151006161911_add_missing_unique_indices.acts_as_taggable_on_engine.rb by rubocop

This cop can check for array literals made up of symbols that are not using the %i() syntax.

Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

Example: EnforcedStyle: percent (default)

# good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

Example: EnforcedStyle: brackets

# good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Open

    remove_index :taggings, name: 'taggings_idx'
Severity: Minor
Found in db/migrate/20151006161911_add_missing_unique_indices.acts_as_taggable_on_engine.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Open

              unique: true, name: 'taggings_idx'
Severity: Minor
Found in db/migrate/20151006161911_add_missing_unique_indices.acts_as_taggable_on_engine.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Use %i or %I for an array of symbols.
Open

    add_index :taggings, [:taggable_id, :taggable_type, :context]
Severity: Minor
Found in db/migrate/20151006161911_add_missing_unique_indices.acts_as_taggable_on_engine.rb by rubocop

This cop can check for array literals made up of symbols that are not using the %i() syntax.

Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

Example: EnforcedStyle: percent (default)

# good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

Example: EnforcedStyle: brackets

# good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

Line is too long. [90/80]
Open

              [:tag_id, :taggable_id, :taggable_type, :context, :tagger_id, :tagger_type],
Severity: Minor
Found in db/migrate/20151006161911_add_missing_unique_indices.acts_as_taggable_on_engine.rb by rubocop

Use %i or %I for an array of symbols.
Open

    remove_index :taggings, [:taggable_id, :taggable_type, :context]
Severity: Minor
Found in db/migrate/20151006161911_add_missing_unique_indices.acts_as_taggable_on_engine.rb by rubocop

This cop can check for array literals made up of symbols that are not using the %i() syntax.

Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

Example: EnforcedStyle: percent (default)

# good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

Example: EnforcedStyle: brackets

# good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

There are no issues that match your filters.

Category
Status