Sign upLogin

18F/e-manifest

View on GitHub
Star
app/models/cdx/logged_request.rb

Summary

Maintainability
A
0 mins
Test Coverage

Space missing to the left of {.
Open

    output_stream.puts ANSI.blue{ self.class.name }
Severity: Minor
Found in app/models/cdx/logged_request.rb by rubocop

Checks that block braces have or don't have a space before the opening brace depending on configuration.

Example:

# bad
foo.map{ |a|
  a.bar.to_s
}

# good
foo.map { |a|
  a.bar.to_s
}

Use nested module/class definitions instead of compact style.
Open

class CDX::LoggedRequest
Severity: Minor
Found in app/models/cdx/logged_request.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

Surrounding space missing in default value assignment.
Open

  def initialize(opts, output_stream=$stdout)
Severity: Minor
Found in app/models/cdx/logged_request.rb by rubocop

Checks that the equals signs in parameter default assignments have or don't have surrounding space depending on configuration.

Example:

# bad
def some_method(arg1=:default, arg2=nil, arg3=[])
  # do something...
end

# good
def some_method(arg1 = :default, arg2 = nil, arg3 = [])
  # do something...
end

Space missing to the left of {.
Open

    output_stream.puts ANSI.blue{ redacted_opts.pretty_inspect }
Severity: Minor
Found in app/models/cdx/logged_request.rb by rubocop

Checks that block braces have or don't have a space before the opening brace depending on configuration.

Example:

# bad
foo.map{ |a|
  a.bar.to_s
}

# good
foo.map { |a|
  a.bar.to_s
}

Parenthesize the param ANSI.green{ response.body.pretty_inspect } to make sure that the block will be associated with the ANSI.green method call.
Open

      output_stream.puts ANSI.green{ response.body.pretty_inspect }
Severity: Minor
Found in app/models/cdx/logged_request.rb by rubocop

This cop checks for ambiguous block association with method when param passed without parentheses.

Example:

# bad
some_method a { |val| puts val }

Example:

# good
# With parentheses, there's no ambiguity.
some_method(a) { |val| puts val }

# good
# Operator methods require no disambiguation
foo == bar { |b| b.baz }

# good
# Lambda arguments require no disambiguation
foo = ->(bar) { bar.baz }

Missing top-level class documentation comment.
Open

class CDX::LoggedRequest
Severity: Minor
Found in app/models/cdx/logged_request.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Parenthesize the param ANSI.blue{ self.class.name } to make sure that the block will be associated with the ANSI.blue method call.
Open

    output_stream.puts ANSI.blue{ self.class.name }
Severity: Minor
Found in app/models/cdx/logged_request.rb by rubocop

This cop checks for ambiguous block association with method when param passed without parentheses.

Example:

# bad
some_method a { |val| puts val }

Example:

# good
# With parentheses, there's no ambiguity.
some_method(a) { |val| puts val }

# good
# Operator methods require no disambiguation
foo == bar { |b| b.baz }

# good
# Lambda arguments require no disambiguation
foo = ->(bar) { bar.baz }

Space missing to the left of {.
Open

      output_stream.puts ANSI.green{ response.body.pretty_inspect }
Severity: Minor
Found in app/models/cdx/logged_request.rb by rubocop

Checks that block braces have or don't have a space before the opening brace depending on configuration.

Example:

# bad
foo.map{ |a|
  a.bar.to_s
}

# good
foo.map { |a|
  a.bar.to_s
}

Parenthesize the param ANSI.blue{ redacted_opts.pretty_inspect } to make sure that the block will be associated with the ANSI.blue method call.
Open

    output_stream.puts ANSI.blue{ redacted_opts.pretty_inspect }
Severity: Minor
Found in app/models/cdx/logged_request.rb by rubocop

This cop checks for ambiguous block association with method when param passed without parentheses.

Example:

# bad
some_method a { |val| puts val }

Example:

# good
# With parentheses, there's no ambiguity.
some_method(a) { |val| puts val }

# good
# Operator methods require no disambiguation
foo == bar { |b| b.baz }

# good
# Lambda arguments require no disambiguation
foo = ->(bar) { bar.baz }

There are no issues that match your filters.

Category
Status