18F/federalist

View on GitHub
frontend/components/site/SitePublishedFilesTable.jsx

Summary

Maintainability
B
4 hrs
Test Coverage

Function renderPagingButtons has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Invalid

function renderPagingButtons(currentPage, lastPage, setCurrentPage) {
  const shouldDisableNextPage = currentPage === lastPage;
  const shouldDisablePreviousPage = currentPage === 0;
  const shouldShowButtons = !(lastPage !== null && lastPage === 0);

Severity: Minor
Found in frontend/components/site/SitePublishedFilesTable.jsx - About 1 hr to fix

    Function SitePublishedFilesTable has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function SitePublishedFilesTable() {
      const { id, name } = useParams();
      const publishedFiles = useSelector(state => state.publishedFiles);
    
      const [currentPage, setCurrentPage] = useState(0);
    Severity: Minor
    Found in frontend/components/site/SitePublishedFilesTable.jsx - About 1 hr to fix

      Function renderPublishedFilesTable has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function renderPublishedFilesTable(files, name, currentPage, lastPage, setCurrentPage) {
      Severity: Minor
      Found in frontend/components/site/SitePublishedFilesTable.jsx - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            case file.publishedBranch.site.defaultBranch:
              viewFileLink = `${file.publishedBranch.site.viewLink}${file.name}`;
              break;
        Severity: Minor
        Found in frontend/components/site/SitePublishedFilesTable.jsx and 1 other location - About 55 mins to fix
        frontend/components/site/SitePublishedFilesTable.jsx on lines 62..64

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            case file.publishedBranch.site.demoBranch:
              viewFileLink = `${file.publishedBranch.site.demoViewLink}${file.name}`;
              break;
        Severity: Minor
        Found in frontend/components/site/SitePublishedFilesTable.jsx and 1 other location - About 55 mins to fix
        frontend/components/site/SitePublishedFilesTable.jsx on lines 59..61

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                <thead>
                  <tr>
                    <th>File</th>
                    <th>Actions</th>
                  </tr>
        Severity: Major
        Found in frontend/components/site/SitePublishedFilesTable.jsx and 2 other locations - About 50 mins to fix
        frontend/components/alertBanner.jsx on lines 17..24
        frontend/components/site/sitePublishedBranchesTable.jsx on lines 46..51

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status