Sign upLogin

18F/federalist

View on GitHub
Star
frontend/components/siteContainer.jsx

Summary

Maintainability
B
6 hrs
Test Coverage
A
97%

Function SiteContainer has 81 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function SiteContainer(props) {
  const { id } = useParams();
  const location = useLocation();
  const params = useSearchParams();
  const sites = useSelector(state => state.sites);
Severity: Major
Found in frontend/components/siteContainer.jsx - About 3 hrs to fix

    Function SiteContainer has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export function SiteContainer(props) {
  const { id } = useParams();
  const location = useLocation();
  const params = useSearchParams();
  const sites = useSelector(state => state.sites);
    Severity: Minor
    Found in frontend/components/siteContainer.jsx - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Wontfix

        return (
      <AlertBanner
        status="error"
        header=""
        message={errorMessage}
    Severity: Major
    Found in frontend/components/siteContainer.jsx - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        return (
    <div className="usa-grid site">
      <SideNav siteId={site.id} config={SITE_NAVIGATION_CONFIG} />
      <div className="usa-width-five-sixths site-main" id="pages-container">
      Severity: Major
      Found in frontend/components/siteContainer.jsx - About 30 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          if (!site.isActive) {
    const errorMessage = (
      <span>
        You don&apos;t have access to this site because it&apos;s inactive,
        please contact support if you believe this is an error.
        Severity: Minor
        Found in frontend/components/siteContainer.jsx and 2 other locations - About 40 mins to fix
        frontend/components/siteContainer.jsx on lines 60..74
        frontend/components/siteContainer.jsx on lines 98..112

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          if (org && !org.isActive) {
    const errorMessage = (
      <span>
        You don&apos;t have access to this site because it&apos;s organization is inactive,
        please contact support if you believe this is an error.
        Severity: Minor
        Found in frontend/components/siteContainer.jsx and 2 other locations - About 40 mins to fix
        frontend/components/siteContainer.jsx on lines 60..74
        frontend/components/siteContainer.jsx on lines 82..96

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          if (!site) {
    const errorMessage = (
      <span>
        You don&apos;t have access to this site,
        please contact the site owner if you believe this is an error.
        Severity: Minor
        Found in frontend/components/siteContainer.jsx and 2 other locations - About 40 mins to fix
        frontend/components/siteContainer.jsx on lines 82..96
        frontend/components/siteContainer.jsx on lines 98..112

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status