Sign upLogin

18F/micropurchase

View on GitHub
Star
app/assets/javascripts/insights/charts.js

Summary

Maintainability
D
2 days
Test Coverage

File charts.js has 335 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

(function (window) {
  var microp = window.microp;
Severity: Minor
Found in app/assets/javascripts/insights/charts.js - About 4 hrs to fix

Function chart5 has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      chart5: function chart5 (settings) {
        c3.generate({
          bindto: '#chart5',
          axis: {
            x: {
Severity: Major
Found in app/assets/javascripts/insights/charts.js - About 2 hrs to fix

Function chart2 has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      chart2: function chart2 (settings) {
        c3.generate({
          bindto: '#chart2',
          data: {
            xs: {
Severity: Major
Found in app/assets/javascripts/insights/charts.js - About 2 hrs to fix

Function chart4 has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      chart4: function chart4 (settings) {

        var today = new Date();
        var twoWeeksAgo = new Date(today - (1000 * 60 * 60 * 24 * 14)); // 14 days ago
        var dateExtent = [twoWeeksAgo,today];
Severity: Major
Found in app/assets/javascripts/insights/charts.js - About 2 hrs to fix

Function chart4 has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      chart4: function chart4 (auctions) {
        var settings = {};
        settings.cols = [
            ['date_community'],
            ['Bidders'],
Severity: Minor
Found in app/assets/javascripts/insights/charts.js - About 1 hr to fix

Function chart2 has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      chart2: function chart2 (auctions) {
        var settings = {};
        settings.cols = [['bids_dates'], ['bids'], ['means_dates'],['means']];

         _.each(auctions, function(auction){
Severity: Minor
Found in app/assets/javascripts/insights/charts.js - About 1 hr to fix

Function chart5 has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      chart5: function chart5 (auctions) {
        var settings = {};
        // set of columns for the scatterplot
        // @format [['date_#{ auction number }', '#{ date }'],['#{ auction number }', #{ number of bids }]]
        settings.cols = [];
Severity: Minor
Found in app/assets/javascripts/insights/charts.js - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        var byGithub = d3.nest()
          .key(function(d){return microp.format.date(d.ended_at)})
          .key(function(d){return d.github_repo})
          .entries(auctions);
Severity: Major
Found in app/assets/javascripts/insights/charts.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/insights/charts.js on lines 320..325

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 76.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        var auctionsByEndtime = d3.nest()
          .key(function(d){
            return microp.format.date(d.ended_at);
          })
          .key(function(d){ return d.id; })
Severity: Major
Found in app/assets/javascripts/insights/charts.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/insights/charts.js on lines 265..268

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 76.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        _.each(auctions, function(auction){
          auction.github_repo = microp.format.standardizeUrl(auction.github_repo);
          auction.github_repo = microp.format.removeGitPrefix(auction.github_repo);
        })
Severity: Major
Found in app/assets/javascripts/insights/charts.js and 1 other location - About 1 hr to fix
app/assets/javascripts/insights/charts.js on lines 260..263

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        _.each(auctions, function(auction){
          auction.github_repo = microp.format.standardizeUrl(auction.github_repo);
          auction.github_repo = microp.format.removeGitPrefix(auction.github_repo);
        })
Severity: Major
Found in app/assets/javascripts/insights/charts.js and 1 other location - About 1 hr to fix
app/assets/javascripts/insights/charts.js on lines 345..348

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status