Sign upLogin

18F/micropurchase

View on GitHub
Star

Showing 122 of 122 total issues

Class AuctionShowViewModel has 36 methods (exceeds 20 allowed). Consider refactoring.
Open

class AuctionShowViewModel
  attr_reader :auction, :current_user

  def initialize(auction:, current_user:, bid_error: nil)
    @auction = auction
Severity: Minor
Found in app/view_models/auction_show_view_model.rb - About 4 hrs to fix

File charts.js has 335 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

(function (window) {
  var microp = window.microp;
Severity: Minor
Found in app/assets/javascripts/insights/charts.js - About 4 hrs to fix

Block has too many lines. [64/25]
Open

Rails.application.routes.draw do
  if Rails.env.development?
    mount LetterOpenerWeb::Engine => "letter_opener"
  end
Severity: Minor
Found in config/routes.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Class WinningBidderExport has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

class WinningBidderExport
  class Error < StandardError; end

  PURCHASE_CARD_AS_PAYMENT_METHOD = 'Y'.freeze
  NATIONAL_INTEREST_ACTION = 'None'.freeze
Severity: Minor
Found in app/models/winning_bidder_export.rb - About 2 hrs to fix

Class AuctionShowViewModel has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

class Admin::AuctionShowViewModel < Admin::BaseViewModel
  attr_reader :auction, :current_user

  def initialize(auction:, current_user:)
    @auction = auction
Severity: Minor
Found in app/view_models/admin/auction_show_view_model.rb - About 2 hrs to fix

Function chart5 has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      chart5: function chart5 (settings) {
        c3.generate({
          bindto: '#chart5',
          axis: {
            x: {
Severity: Major
Found in app/assets/javascripts/insights/charts.js - About 2 hrs to fix

Class AuctionListItem has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

class AuctionListItem
  attr_reader :auction, :current_user

  def initialize(auction:, current_user:)
    @auction = auction
Severity: Minor
Found in app/view_models/auction_list_item.rb - About 2 hrs to fix

Class BidStatusPresenterFactory has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

class BidStatusPresenterFactory
  attr_reader :auction, :user, :bid_error

  def initialize(auction:, user:, bid_error: nil)
    @auction = auction
Severity: Minor
Found in app/models/bid_status_presenter_factory.rb - About 2 hrs to fix

Method has too many lines. [24/20]
Open

  def data_values
    [
      legal_business_name,
      address_line_1,
      address_line_2,
Severity: Minor
Found in app/models/winning_bidder_export.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [24/20]
Open

  def header_values
    [
      "13GG Vendor Name",
      "13JJ Vendor Address Line 1",
      '13KK Vendor Address Line 2',
Severity: Minor
Found in app/models/winning_bidder_export.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Function chart2 has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      chart2: function chart2 (settings) {
        c3.generate({
          bindto: '#chart2',
          data: {
            xs: {
Severity: Major
Found in app/assets/javascripts/insights/charts.js - About 2 hrs to fix

Function chart4 has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      chart4: function chart4 (settings) {

        var today = new Date();
        var twoWeeksAgo = new Date(today - (1000 * 60 * 60 * 24 * 14)); // 14 days ago
        var dateExtent = [twoWeeksAgo,today];
Severity: Major
Found in app/assets/javascripts/insights/charts.js - About 2 hrs to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        var auctionsByEndtime = d3.nest()
          .key(function(d){
            return microp.format.date(d.ended_at);
          })
          .key(function(d){ return d.id; })
Severity: Major
Found in app/assets/javascripts/insights/charts.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/insights/charts.js on lines 265..268

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 76.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        var byGithub = d3.nest()
          .key(function(d){return microp.format.date(d.ended_at)})
          .key(function(d){return d.github_repo})
          .entries(auctions);
Severity: Major
Found in app/assets/javascripts/insights/charts.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/insights/charts.js on lines 320..325

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 76.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        _.each(auctions, function(auction){
          auction.github_repo = microp.format.standardizeUrl(auction.github_repo);
          auction.github_repo = microp.format.removeGitPrefix(auction.github_repo);
        })
Severity: Major
Found in app/assets/javascripts/insights/charts.js and 1 other location - About 1 hr to fix
app/assets/javascripts/insights/charts.js on lines 345..348

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        _.each(auctions, function(auction){
          auction.github_repo = microp.format.standardizeUrl(auction.github_repo);
          auction.github_repo = microp.format.removeGitPrefix(auction.github_repo);
        })
Severity: Major
Found in app/assets/javascripts/insights/charts.js and 1 other location - About 1 hr to fix
app/assets/javascripts/insights/charts.js on lines 260..263

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Cyclomatic complexity for available_message is too high. [7/6]
Open

  def available_message
    if admin?
      AdminAuctionStatusPresenter::Available
    elsif guest?
      BidStatusPresenter::Available::Guest
Severity: Minor
Found in app/models/bid_status_presenter_factory.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Perceived complexity for available_message is too high. [8/7]
Open

  def available_message
    if admin?
      AdminAuctionStatusPresenter::Available
    elsif guest?
      BidStatusPresenter::Available::Guest
Severity: Minor
Found in app/models/bid_status_presenter_factory.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Function chart4 has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      chart4: function chart4 (auctions) {
        var settings = {};
        settings.cols = [
            ['date_community'],
            ['Bidders'],
Severity: Minor
Found in app/assets/javascripts/insights/charts.js - About 1 hr to fix

Block has too many lines. [35/25]
Open

  included do
    scope :accepted, -> { where(delivery_status: delivery_statuses['accepted']) }
    scope :accepted_pending_payment_url, lambda {
      where(delivery_status: delivery_statuses['accepted_pending_payment_url'])
    }
Severity: Minor
Found in app/models/concerns/auction_scopes.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Severity
Category
Status
Source
Language