Sign upLogin

18F/openFEC

View on GitHub
Star
webservices/filters.py

Summary

Maintainability
B
4 hrs
Test Coverage

Function filter_multi has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def filter_multi(query, kwargs, fields):
    for key, column in fields:
        if kwargs.get(key):
            # handle combination exclude/include lists
            exclude_list = [parse_exclude_arg(value) for value in kwargs[key] if is_exclude_arg(value)]
Severity: Minor
Found in webservices/filters.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function filter_fulltext has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def filter_fulltext(query, kwargs, fields):
    for key, column in fields:
        if kwargs.get(key):
            exclude_list = [parse_exclude_arg(value) for value in kwargs[key] if is_exclude_arg(value)]
            include_list = [value for value in kwargs[key] if not is_exclude_arg(value)]
Severity: Minor
Found in webservices/filters.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function filter_election has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def filter_election(query, kwargs, candidate_column, cycle_column=None, year_column=None):
Severity: Minor
Found in webservices/filters.py - About 35 mins to fix

    Function filter_match has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def filter_match(query, kwargs, fields):
    for key, column in fields:
        if kwargs.get(key) is not None:
            if is_exclude_arg(kwargs[key]):
                query = query.filter(sa.or_(column != parse_exclude_arg(kwargs[key]),
    Severity: Minor
    Found in webservices/filters.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if kwargs.get('district'):
        query = query.filter(models.CandidateHistory.district == kwargs['district'])
    Severity: Minor
    Found in webservices/filters.py and 1 other location - About 55 mins to fix
    webservices/filters.py on lines 95..96

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if kwargs.get('state'):
        query = query.filter(models.CandidateHistory.state == kwargs['state'])
    Severity: Minor
    Found in webservices/filters.py and 1 other location - About 55 mins to fix
    webservices/filters.py on lines 97..98

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status