Sign upLogin

18F/openFEC

View on GitHub
Star
webservices/rest.py

Summary

Maintainability
B
4 hrs
Test Coverage

File rest.py has 354 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""
A RESTful web service supporting fulltext and field-specific searches on FEC data. For
full documentation visit: https://api.open.fec.gov/developers.
"""
from webservices.env import env
Severity: Minor
Found in webservices/rest.py - About 4 hrs to fix

    Function limit_remote_addr has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def limit_remote_addr():
    """If `FEC_API_WHITELIST_IPS` is set, reject all requests that are not
    routed through the API Umbrella.
    """
    falses = (False, 'False', 'false', 'f')
    Severity: Minor
    Found in webservices/rest.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status