Sign upLogin

18F/openFEC

View on GitHub
Star
webservices/sorting.py

Summary

Maintainability
B
5 hrs
Test Coverage

Function parse_option has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

def parse_option(option, model=None, aliases=None, join_columns=None, query=None):
    """Parse sort option to SQLAlchemy order expression.

    :param str option: Column name, possibly prefixed with "-"
    :param model: Optional SQLAlchemy model to sort on
Severity: Minor
Found in webservices/sorting.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function sort has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

def sort(query, key, model, aliases=None, join_columns=None, clear=False,
         hide_null=False, index_column=None):
    """Sort query using string-formatted columns.

    :param query: Original query
Severity: Minor
Found in webservices/sorting.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function multi_sort has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

def multi_sort(query, keys, model, aliases=None, join_columns=None, clear=False,
Severity: Major
Found in webservices/sorting.py - About 1 hr to fix

    Function sort has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def sort(query, key, model, aliases=None, join_columns=None, clear=False,
    Severity: Major
    Found in webservices/sorting.py - About 1 hr to fix

      Function parse_option has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def parse_option(option, model=None, aliases=None, join_columns=None, query=None):
      Severity: Minor
      Found in webservices/sorting.py - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status