1ma/UMAPsr7HmacBundle

Avoid variables with short names like $id. Configured minimum length is 3.

Open

    public function create(ContainerBuilder $container, $id, $config, $userProvider, $defaultEntryPoint)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function __construct($apiKeyHeader, AuthenticationManagerInterface $authManager, TokenStorageInterface $tokenStorage, AuthenticationEntryPointInterface $entryPoint = null, LoggerInterface $logger = null)

Method create has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function create(ContainerBuilder $container, $id, $config, $userProvider, $defaultEntryPoint)

Missing class import via use statement (line '155', column '23').

Open

            throw new \InvalidArgumentException(sprintf('This token has no "%s" attribute.', $name));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '221', column '27').

Open

                throw new \InvalidArgumentException(sprintf('User roles must be an array of strings, or RoleInterface instances, but got %s.', gettype($role)));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Avoid assigning values to variables in if clauses and the like (line '67', column '26').

Open

    public function handle(GetResponseEvent $event)
    {
        $request = $event->getRequest();

        try {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Avoid assigning values to variables in if clauses and the like (line '64', column '22').

Open

    public function authenticate(TokenInterface $token)
    {
        $apiUser = $this->userProvider
            ->loadUserByUsername($token->getUsername());

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}