Sign upLogin

1set/gut

View on GitHub
Star

Showing 12 of 14 total issues

Function ListMatch has a Cognitive Complexity of 33 (exceeds 20 allowed). Consider refactoring.
Open

func ListMatch(root string, flag int, patterns ...string) (entries []*FilePathInfo, err error) {
    var (
        rePatterns   []*regexp.Regexp
        typeFlag     = flag & ListIncludeAll
        useRegExp    = flag&ListUseRegExp != 0
Severity: Minor
Found in yos/list.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function copyDir has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
Open

func copyDir(src, dest string) (err error) {
    var srcInfo, destInfo os.FileInfo

    // check if source exists and is a directory
    if srcInfo, err = os.Stat(src); err == nil {
Severity: Minor
Found in yos/copy.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function bufferCopyFile has 57 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func bufferCopyFile(src, dest string, bufferSize int64) (err error) {
    var (
        srcFile, destFile *os.File
        srcInfo, destInfo os.FileInfo
    )
Severity: Minor
Found in yos/copy.go - About 1 hr to fix

    Function bufferCopyFile has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
    Open

    func bufferCopyFile(src, dest string, bufferSize int64) (err error) {
    var (
        srcFile, destFile *os.File
        srcInfo, destInfo os.FileInfo
    )
    Severity: Minor
    Found in yos/copy.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func TrimBeforeLast(s, substr string) string {
    switch ls, lsub := len(s), len(substr); {
    case ls == 0 || lsub == 0:
        return s
    case ls < lsub:
    Severity: Minor
    Found in ystring/trim.go and 1 other location - About 50 mins to fix
    ystring/trim.go on lines 41..53

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func TrimBeforeFirst(s, substr string) string {
    switch ls, lsub := len(s), len(substr); {
    case ls == 0 || lsub == 0:
        return s
    case ls < lsub:
    Severity: Minor
    Found in ystring/trim.go and 1 other location - About 50 mins to fix
    ystring/trim.go on lines 57..69

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func TrimAfterLast(s, substr string) string {
    switch ls, lsub := len(s), len(substr); {
    case ls == 0 || lsub == 0:
        return s
    case ls < lsub:
    Severity: Minor
    Found in ystring/trim.go and 1 other location - About 45 mins to fix
    ystring/trim.go on lines 9..21

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 117.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func TrimAfterFirst(s, substr string) string {
    switch ls, lsub := len(s), len(substr); {
    case ls == 0 || lsub == 0:
        return s
    case ls < lsub:
    Severity: Minor
    Found in ystring/trim.go and 1 other location - About 45 mins to fix
    ystring/trim.go on lines 25..37

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 117.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function SameDirEntries has 7 return statements (exceeds 4 allowed).
    Open

    func SameDirEntries(path1, path2 string) (same bool, err error) {
    var (
        fi1, fi2       os.FileInfo
        raw1, raw2     = path1, path2
        items1, items2 []*FilePathInfo
    Severity: Major
    Found in yos/compare.go - About 45 mins to fix

      Function SameDirEntries has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
      Open

      func SameDirEntries(path1, path2 string) (same bool, err error) {
    var (
        fi1, fi2       os.FileInfo
        raw1, raw2     = path1, path2
        items1, items2 []*FilePathInfo
      Severity: Minor
      Found in yos/compare.go - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function SameFileContent has 6 return statements (exceeds 4 allowed).
      Open

      func SameFileContent(path1, path2 string) (same bool, err error) {
    if path1, path2, err = refineComparePaths(path1, path2); err != nil {
        return
    }
      Severity: Major
      Found in yos/compare.go - About 40 mins to fix

        Function moveEntry has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func moveEntry(src, dest string, check funcCheckFileInfo, errMode error, remove funcRemoveEntry, copy funcCopyEntry) (err error) {
        Severity: Minor
        Found in yos/move.go - About 35 mins to fix
          Severity
          Category
          Status
          Source
          Language