Sign upLogin

1set/starlet

View on GitHub
Star
lib/random/random.go

Summary

Maintainability
C
1 day
Test Coverage

Function choices has a Cognitive Complexity of 39 (exceeds 20 allowed). Consider refactoring.
Open

func choices(thread *starlark.Thread, bn *starlark.Builtin, args starlark.Tuple, kwargs []starlark.Tuple) (starlark.Value, error) {
    var (
        population  starlark.Indexable
        weights     *starlark.List
        cumWeights  *starlark.List
Severity: Minor
Found in lib/random/random.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function choices has 86 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func choices(thread *starlark.Thread, bn *starlark.Builtin, args starlark.Tuple, kwargs []starlark.Tuple) (starlark.Value, error) {
    var (
        population  starlark.Indexable
        weights     *starlark.List
        cumWeights  *starlark.List
Severity: Major
Found in lib/random/random.go - About 2 hrs to fix

    Function choices has 14 return statements (exceeds 4 allowed).
    Open

    func choices(thread *starlark.Thread, bn *starlark.Builtin, args starlark.Tuple, kwargs []starlark.Tuple) (starlark.Value, error) {
    var (
        population  starlark.Indexable
        weights     *starlark.List
        cumWeights  *starlark.List
    Severity: Major
    Found in lib/random/random.go - About 1 hr to fix

      Function shuffle has 8 return statements (exceeds 4 allowed).
      Open

      func shuffle(thread *starlark.Thread, bn *starlark.Builtin, args starlark.Tuple, kwargs []starlark.Tuple) (starlark.Value, error) {
    // precondition checks
    var seq starlark.HasSetIndex
    if err := starlark.UnpackArgs(bn.Name(), args, kwargs, "seq", &seq); err != nil {
        return nil, err
      Severity: Major
      Found in lib/random/random.go - About 50 mins to fix

        There are no issues that match your filters.

        Category
        Status