Sign upLogin

1set/starlet

View on GitHub
Star
run.go

Summary

Maintainability
B
5 hrs
Test Coverage

Method Machine.runInternal has a Cognitive Complexity of 32 (exceeds 20 allowed). Consider refactoring.
Open

func (m *Machine) runInternal(ctx context.Context, extras StringAnyMap, allowCache bool) (out StringAnyMap, err error) {
    defer func() {
        if r := recover(); r != nil {
            err = errorStarlarkPanic("exec", r)
        }
Severity: Minor
Found in run.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Machine.runInternal has 73 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (m *Machine) runInternal(ctx context.Context, extras StringAnyMap, allowCache bool) (out StringAnyMap, err error) {
    defer func() {
        if r := recover(); r != nil {
            err = errorStarlarkPanic("exec", r)
        }
Severity: Minor
Found in run.go - About 1 hr to fix

    Method Machine.prepareThread has 10 return statements (exceeds 4 allowed).
    Open

    func (m *Machine) prepareThread(extras StringAnyMap) (err error) {
    mergeExtra := func() error {
        // no extras
        if extras == nil {
            return nil
    Severity: Major
    Found in run.go - About 1 hr to fix

      Method Machine.runInternal has 6 return statements (exceeds 4 allowed).
      Open

      func (m *Machine) runInternal(ctx context.Context, extras StringAnyMap, allowCache bool) (out StringAnyMap, err error) {
    defer func() {
        if r := recover(); r != nil {
            err = errorStarlarkPanic("exec", r)
        }
      Severity: Major
      Found in run.go - About 40 mins to fix

        There are no issues that match your filters.

        Category
        Status