Sign upLogin

2018-SWENG/2018-SWENG-Radius

View on GitHub
Star
app/src/main/java/ch/epfl/sweng/radius/database/OthersInfo.java

Summary

Maintainability
A
3 hrs
Test Coverage

OthersInfo has 31 methods (exceeds 20 allowed). Consider refactoring.
Open

public class OthersInfo extends DBObservable{
    public Timer timer = new Timer(true);
    private final int REFRESH_PERIOD = 5; // in seconds

    private static OthersInfo othersInfo = null;
Severity: Minor
Found in app/src/main/java/ch/epfl/sweng/radius/database/OthersInfo.java - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Invalid

        public void fetchFriends(){
        List<String> ids = new ArrayList<>(UserInfo.getInstance().getCurrentUser().getFriends().values());
        database.readListObjOnce(ids, Database.Tables.LOCATIONS, new CallBackDatabase() {
            @Override
            public void onFinish(Object value) {
    Severity: Minor
    Found in app/src/main/java/ch/epfl/sweng/radius/database/OthersInfo.java and 1 other location - About 55 mins to fix
    app/src/main/java/ch/epfl/sweng/radius/database/OthersInfo.java on lines 213..226

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 65.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Invalid

        public void fetchRequest(){
        List<String> ids = new ArrayList<>(UserInfo.getInstance().getCurrentUser().getFriendsInvitations().values());
        database.readListObjOnce(ids, Database.Tables.LOCATIONS, new CallBackDatabase() {
            @Override
            public void onFinish(Object value) {
    Severity: Minor
    Found in app/src/main/java/ch/epfl/sweng/radius/database/OthersInfo.java and 1 other location - About 55 mins to fix
    app/src/main/java/ch/epfl/sweng/radius/database/OthersInfo.java on lines 195..208

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 65.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status