Sign upLogin

2018-SWENG/2018-SWENG-Radius

View on GitHub
Star
app/src/main/java/ch/epfl/sweng/radius/home/HomeFragment.java

Summary

Maintainability
A
2 hrs
Test Coverage

HomeFragment has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

public class HomeFragment extends Fragment implements OnMapReadyCallback, DBLocationObserver {

    //constants
    private static final String TAG = "HomeFragment";
    private static float ZOOM = 13f/2;
Severity: Minor
Found in app/src/main/java/ch/epfl/sweng/radius/home/HomeFragment.java - About 2 hrs to fix

    Method markNearbyUser has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Invalid

        public void markNearbyUser(int indexOfUser, String status, String userName, String locID) {
        if(!usersLoc.get(indexOfUser).getVisible()) return;
        LatLng newPos = new LatLng(usersLoc.get(indexOfUser).getLatitude(),
                                    usersLoc.get(indexOfUser).getLongitude()    );
        float color = friendsID.containsKey(locID) ? BitmapDescriptorFactory.HUE_BLUE :
    Severity: Minor
    Found in app/src/main/java/ch/epfl/sweng/radius/home/HomeFragment.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method markNearbyUser has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Invalid

        public void markNearbyUser(int indexOfUser, String status, String userName, String locID) {
        if(!usersLoc.get(indexOfUser).getVisible()) return;
        LatLng newPos = new LatLng(usersLoc.get(indexOfUser).getLatitude(),
                                    usersLoc.get(indexOfUser).getLongitude()    );
        float color = friendsID.containsKey(locID) ? BitmapDescriptorFactory.HUE_BLUE :
    Severity: Minor
    Found in app/src/main/java/ch/epfl/sweng/radius/home/HomeFragment.java - About 1 hr to fix

      Method onMapReady has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Wontfix

          @Override
    public void onMapReady(GoogleMap googleMap) {
        Toast.makeText(getContext(), "Map is ready", Toast.LENGTH_SHORT).show();
        if(googleMap == null)
            return;
      Severity: Minor
      Found in app/src/main/java/ch/epfl/sweng/radius/home/HomeFragment.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status