Sign upLogin

29decibel/kindler

View on GitHub
Star

Showing 2 of 2 total issues

Class Book has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Book
    class KindlerError < StandardError;end

    attr_accessor :title,:author,:pages,:pages_by_section,:local_images,:mobi_type,:style,:cover_image
Severity: Minor
Found in lib/kindler.rb - About 2 hrs to fix

    Method add_page has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def add_page(options={})
      raise KindlerError.new('must provide title when add page') unless options[:title]
      page = options.reject{|k,v| PAGE_ATTRIBUTES.include?(k)}
      page[:wrap] ||= true
      page[:section] ||= DEFAULT_SECTION
    Severity: Minor
    Found in lib/kindler.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language