Showing 4 of 5 total issues
File homecontrol.py
has 430 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
"""devolo Home Control."""
from __future__ import annotations
import threading
from typing import Any
File updater.py
has 372 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
"""The Updater."""
from __future__ import annotations
import json
import logging
Updater
has 33 functions (exceeds 20 allowed). Consider refactoring. Open
Open
class Updater:
"""
The Updater takes care of new states and values of devices and sends them to the Publisher object. Using methods in here
do not effect the real device states.
Function _inspect_devices
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
def _inspect_devices(self, devices: list[str]) -> None:
"""Inspect device properties of given list of devices."""
devices_properties = self.get_data_from_uid_list(devices)
for device_properties in devices_properties:
properties = device_properties["properties"]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"