Sign upLogin

3scale/porta

View on GitHub
Star
app/controllers/admin/fields_definitions_controller.rb

Summary

Maintainability
A
0 mins
Test Coverage

Admin::FieldsDefinitionsController#edit calls 'field_definition.target_class' 2 times
Open

    @optional_fields = field_definition.target_class.builtin_fields
    @required_fields = field_definition.target_class.required_fields
Severity: Minor
Found in app/controllers/admin/fields_definitions_controller.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Admin::FieldsDefinitionsController#create calls '@fields_definition.target' 2 times
Open

      @optional_fields = @fields_definition.target.classify.constantize.builtin_fields -
          current_account.reload.fields_definitions.by_target(@fields_definition.target).map(&:name)
Severity: Minor
Found in app/controllers/admin/fields_definitions_controller.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Admin::FieldsDefinitionsController#new calls '@fields_definition.target_class' 2 times
Open

    @optional_fields = @fields_definition.target_class.builtin_fields -
      current_account.fields_definitions.by_target(target).map{ |f|f.name }

    @required_fields = @fields_definition.target_class.required_fields
Severity: Minor
Found in app/controllers/admin/fields_definitions_controller.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Admin::FieldsDefinitionsController#new has the variable name 'f'
Open

      current_account.fields_definitions.by_target(target).map{ |f|f.name }
Severity: Minor
Found in app/controllers/admin/fields_definitions_controller.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

There are no issues that match your filters.

Category
Status