Sign upLogin

3scale/porta

View on GitHub
Star
app/controllers/provider/admin/cms/templates_controller.rb

Summary

Maintainability
A
0 mins
Test Coverage

Provider::Admin::CMS::TemplatesController#update has approx 16 statements
Open

  def update
Severity: Minor
Found in app/controllers/provider/admin/cms/templates_controller.rb by reek

A method with Too Many Statements is any method that has a large number of lines.

Too Many Statements warns about any method that has more than 5 statements. Reek's smell detector for Too Many Statements counts +1 for every simple statement in a method and +1 for every statement within a control structure (if, else, case, when, for, while, until, begin, rescue) but it doesn't count the control structure itself.

So the following method would score +6 in Reek's statement-counting algorithm:

def parse(arg, argv, &error)
  if !(val = arg) and (argv.empty? or /\A-/ =~ (val = argv[0]))
    return nil, block, nil                                         # +1
  end
  opt = (val = parse_arg(val, &error))[1]                          # +2
  val = conv_arg(*val)                                             # +3
  if opt and !arg
    argv.shift                                                     # +4
  else
    val[0] = nil                                                   # +5
  end
  val                                                              # +6
end

(You might argue that the two assigments within the first @if@ should count as statements, and that perhaps the nested assignment should count as +2.)

Provider::Admin::CMS::TemplatesController#update calls 'format.js' 2 times
Open

        format.js do
          flash.now[:notice] = msg
          render template: '/provider/admin/cms/templates/update'
        end
      end
Severity: Minor
Found in app/controllers/provider/admin/cms/templates_controller.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Provider::Admin::CMS::TemplatesController#publish_or_hide_page_with_message calls '@page.class' 3 times
Open

      return "#{@page.class.model_name.human} saved and published."
    elsif params[:hide]
      @page.hide!
      return "#{@page.class.model_name.human} has been hidden."
    else
Severity: Minor
Found in app/controllers/provider/admin/cms/templates_controller.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Provider::Admin::CMS::TemplatesController#update calls 'format.html' 2 times
Open

        format.html do
          flash[:notice] = msg
          redirect_to(action: :edit, id: @page.id)
        end
Severity: Minor
Found in app/controllers/provider/admin/cms/templates_controller.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Provider::Admin::CMS::TemplatesController#update calls 'render template: '/provider/admin/cms/templates/update'' 2 times
Open

          render template: '/provider/admin/cms/templates/update'
        end
      end
    else
      respond_to do |format|
Severity: Minor
Found in app/controllers/provider/admin/cms/templates_controller.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Provider::Admin::CMS::TemplatesController#publish_or_hide_page_with_message calls '@page.class.model_name' 3 times
Open

      return "#{@page.class.model_name.human} saved and published."
    elsif params[:hide]
      @page.hide!
      return "#{@page.class.model_name.human} has been hidden."
    else
Severity: Minor
Found in app/controllers/provider/admin/cms/templates_controller.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Provider::Admin::CMS::TemplatesController#publish_or_hide_page_with_message calls '@page.class.model_name.human' 3 times
Open

      return "#{@page.class.model_name.human} saved and published."
    elsif params[:hide]
      @page.hide!
      return "#{@page.class.model_name.human} has been hidden."
    else
Severity: Minor
Found in app/controllers/provider/admin/cms/templates_controller.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

There are no issues that match your filters.

Category
Status