Sign upLogin

3scale/porta

View on GitHub
Star
app/events/posts/post_created_event.rb

Summary

Maintainability
A
0 mins
Test Coverage

Posts::PostCreatedEvent#main_attributes calls 'post.forum' 2 times
Open

        forum:    post.forum,
        provider: provider = post.forum.account,
Severity: Minor
Found in app/events/posts/post_created_event.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Posts::PostCreatedEvent#create calls 'post.user' 2 times
Open

      attributes = if post.user.blank?
                     main_attributes(post)
                   else
                     main_attributes(post).merge(user_attributes(post.user))
Severity: Minor
Found in app/events/posts/post_created_event.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Posts::PostCreatedEvent#create calls 'main_attributes(post)' 2 times
Open

                     main_attributes(post)
                   else
                     main_attributes(post).merge(user_attributes(post.user))
Severity: Minor
Found in app/events/posts/post_created_event.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

There are no issues that match your filters.

Category
Status