Sign upLogin

3scale/porta

View on GitHub
Star
app/helpers/buyers/accounts_helper.rb

Summary

Maintainability
A
55 mins
Test Coverage

Method link_to_buyer_or_deleted has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def link_to_buyer_or_deleted( buyer, path_method = :admin_buyers_account_path)
    if buyer
      if can? :manage, :partners
        path = path_method.is_a?(Symbol) ? send( path_method, buyer) : path_method
        link_to buyer.org_name, path, title: account_title(buyer)
Severity: Minor
Found in app/helpers/buyers/accounts_helper.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Buyers::AccountsHelper#public_domain calls 'account.site_access_code' 2 times
Open

    access_code = "/access_code?access_code=#{account.site_access_code}" if account.site_access_code
Severity: Minor
Found in app/helpers/buyers/accounts_helper.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Buyers::AccountsHelper#link_to_buyer_or_deleted calls 'buyer.org_name' 2 times
Open

        link_to buyer.org_name, path, title: account_title(buyer)
      else
        buyer.org_name
Severity: Minor
Found in app/helpers/buyers/accounts_helper.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

There are no issues that match your filters.

Category
Status