Sign upLogin

3scale/porta

View on GitHub
Star
app/helpers/pricing_rules_helper.rb

Summary

Maintainability
A
0 mins
Test Coverage

PricingRulesHelper#display_pricing_rule_range calls 'pricing_rule.metric' 2 times
Open

      "#{pricing_rule.min} - #{pricing_rule.max} #{pricing_rule.metric.unit}"
    else
      "more than #{pricing_rule.min - 1} #{pricing_rule.metric.unit}"
Severity: Minor
Found in app/helpers/pricing_rules_helper.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

PricingRulesHelper#display_pricing_rule_range calls 'pricing_rule.metric.unit' 2 times
Open

      "#{pricing_rule.min} - #{pricing_rule.max} #{pricing_rule.metric.unit}"
    else
      "more than #{pricing_rule.min - 1} #{pricing_rule.metric.unit}"
Severity: Minor
Found in app/helpers/pricing_rules_helper.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

PricingRulesHelper#display_pricing_rule_range calls 'pricing_rule.min' 2 times
Open

      "#{pricing_rule.min} - #{pricing_rule.max} #{pricing_rule.metric.unit}"
    else
      "more than #{pricing_rule.min - 1} #{pricing_rule.metric.unit}"
Severity: Minor
Found in app/helpers/pricing_rules_helper.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

PricingRulesHelper#display_pricing_rule_range calls 'pricing_rule.max' 2 times
Open

    if pricing_rule.max
      "#{pricing_rule.min} - #{pricing_rule.max} #{pricing_rule.metric.unit}"
Severity: Minor
Found in app/helpers/pricing_rules_helper.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

There are no issues that match your filters.

Category
Status