Sign upLogin

3scale/porta

View on GitHub
Star
app/lib/backend/model_extensions/cinstance.rb

Summary

Maintainability
A
0 mins
Test Coverage

Backend::ModelExtensions::Cinstance#update_backend_user_key_to_application_id_mapping calls 'service.backend_id' 2 times
Open

          ThreeScale::Core::Application.delete_id_by_key(service.backend_id, user_key_was)
        end

        ## save no matter what, even if not changed, it's safe. Required for backend rake task that are
        ## unaware of previous changes
Severity: Minor
Found in app/lib/backend/model_extensions/cinstance.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Backend::ModelExtensions::Cinstance#update_backend_user_key_to_application_id_mapping performs a nil-check
Open

        if !service.nil? && user_key.present?
Severity: Minor
Found in app/lib/backend/model_extensions/cinstance.rb by reek

A NilCheck is a type check. Failures of NilCheck violate the "tell, don't ask" principle.

Additionally, type checks often mask bigger problems in your source code like not using OOP and / or polymorphism when you should.

Example

Given

class Klass
  def nil_checker(argument)
    if argument.nil?
      puts "argument isn't nil!"
    end
  end
end

Reek would emit the following warning:

test.rb -- 1 warning:
  [3]:Klass#nil_checker performs a nil-check. (NilCheck)

There are no issues that match your filters.

Category
Status