Sign upLogin

3scale/porta

View on GitHub
Star
app/lib/backend_client/request.rb

Summary

Maintainability
A
0 mins
Test Coverage

BackendClient::Request#max_tries doesn't depend on instance state (maybe move it to another class?)
Open

    def max_tries
Severity: Minor
Found in app/lib/backend_client/request.rb by reek

A Utility Function is any instance method that has no dependency on the state of the instance.

BackendClient::Request#default_options doesn't depend on instance state (maybe move it to another class?)
Open

    def default_options
Severity: Minor
Found in app/lib/backend_client/request.rb by reek

A Utility Function is any instance method that has no dependency on the state of the instance.

BackendClient::Request#with_retries has the variable name 'n'
Open

      max_tries.times do |n|
Severity: Minor
Found in app/lib/backend_client/request.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

There are no issues that match your filters.

Category
Status