Sign upLogin

3scale/porta

View on GitHub
Star
app/lib/backend_client/toggle_backend.rb

Summary

Maintainability
A
0 mins
Test Coverage

BackendClient::ToggleBackend declares the class variable '@@bases'
Open

    @@bases = Set.new

    def self.disable_all!
      each(&:disable_backend!)
    end
Severity: Minor
Found in app/lib/backend_client/toggle_backend.rb by reek

Class variables form part of the global runtime state, and as such make it easy for one part of the system to accidentally or inadvertently depend on another part of the system. So the system becomes more prone to problems where changing something over here breaks something over there. In particular, class variables can make it hard to set up tests (because the context of the test includes all global state).

For a detailed explanation, check out this article

Example

Given

class Dummy
  @@class_variable = :whatever
end

Reek would emit the following warning:

reek test.rb

test.rb -- 1 warning:
  [2]:Dummy declares the class variable @@class_variable (ClassVariable)

Getting rid of the smell

You can use class-instance variable to mitigate the problem (as also suggested in the linked article above):

class Dummy
  @class_variable = :whatever
end

There are no issues that match your filters.

Category
Status