Sign upLogin

3scale/porta

View on GitHub
Star
app/lib/forum_support/topics.rb

Summary

Maintainability
A
0 mins
Test Coverage

ForumSupport::Topics#show calls '@topic.posts' 2 times
Open

    @posts = @topic.posts.includes(:topic, :user).paginate(:page => params[:page], :per_page => 20)
    @post  = @topic.posts.build
Severity: Minor
Found in app/lib/forum_support/topics.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

ForumSupport::Topics#authorize_topic calls 'params[:action]' 2 times
Open

      if params[:action].to_sym == :show
        authorize! :read, @topic
      else # other permissions should be ok
        authorize! params[:action].to_sym, @topic
Severity: Minor
Found in app/lib/forum_support/topics.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

ForumSupport::Topics#authorize_topic calls 'params[:action].to_sym' 2 times
Open

      if params[:action].to_sym == :show
        authorize! :read, @topic
      else # other permissions should be ok
        authorize! params[:action].to_sym, @topic
Severity: Minor
Found in app/lib/forum_support/topics.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

There are no issues that match your filters.

Category
Status