Sign upLogin

3scale/porta

View on GitHub
Star
app/mailers/mail_preview.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Class MailPreview has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

class MailPreview < MailView
  FakeContract = Struct.new(:id, :old_plan, :plan, :provider_account, :service, :account, :name)

  def application_created
    event = Applications::ApplicationCreatedEvent.create(Cinstance.last, User.last)
Severity: Minor
Found in app/mailers/mail_preview.rb - About 3 hrs to fix

    MailPreview#plan_downgraded refers to 'plans' more than self (maybe move it to another class?)
    Open

        event = Plans::PlanDowngradedEvent.create(plans.first, plans.second, Contract.last)
    Severity: Minor
    Found in app/mailers/mail_preview.rb by reek

    Feature Envy occurs when a code fragment references another object more often than it references itself, or when several clients do the same series of manipulations on a particular type of object.

    Feature Envy reduces the code's ability to communicate intent: code that "belongs" on one class but which is located in another can be hard to find, and may upset the "System of Names" in the host class.

    Feature Envy also affects the design's flexibility: A code fragment that is in the wrong class creates couplings that may not be natural within the application's domain, and creates a loss of cohesion in the unwilling host class.

    Feature Envy often arises because it must manipulate other objects (usually its arguments) to get them into a useful form, and one force preventing them (the arguments) doing this themselves is that the common knowledge lives outside the arguments, or the arguments are of too basic a type to justify extending that type. Therefore there must be something which 'knows' about the contents or purposes of the arguments. That thing would have to be more than just a basic type, because the basic types are either containers which don't know about their contents, or they are single objects which can't capture their relationship with their fellows of the same type. So, this thing with the extra knowledge should be reified into a class, and the utility method will most likely belong there.

    Example

    Running Reek on:

    class Warehouse
  def sale_price(item)
    (item.price - item.rebate) * @vat
  end
end

    would report:

    Warehouse#total_price refers to item more than self (FeatureEnvy)

    since this:

    (item.price - item.rebate)

    belongs to the Item class, not the Warehouse.

    MailPreview has at least 27 methods
    Open

    class MailPreview < MailView
    Severity: Minor
    Found in app/mailers/mail_preview.rb by reek

    Too Many Methods is a special case of LargeClass.

    Example

    Given this configuration

    TooManyMethods:
  max_methods: 3

    and this code:

    class TooManyMethods
  def one; end
  def two; end
  def three; end
  def four; end
end

    Reek would emit the following warning:

    test.rb -- 1 warning:
  [1]:TooManyMethods has at least 4 methods (TooManyMethods)

    There are no issues that match your filters.

    Category
    Status