Sign upLogin

3scale/porta

View on GitHub
Star
app/models/api_docs/mailer.rb

Summary

Maintainability
A
0 mins
Test Coverage

ApiDocs::Mailer#new_path_notification calls 'service.account' 3 times
Open

    @account = service.account
    @base_path = service.base_path
    @reply_to = service.account.support_email

    mail(:subject =>  "New ActiveDocs Path added: #{service.base_path}",
Severity: Minor
Found in app/models/api_docs/mailer.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

ApiDocs::Mailer#new_path_notification calls 'service.account.support_email' 2 times
Open

    @reply_to = service.account.support_email

    mail(:subject =>  "New ActiveDocs Path added: #{service.base_path}",
         :to => support_email,
         :from => service.account.support_email)
Severity: Minor
Found in app/models/api_docs/mailer.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

ApiDocs::Mailer#new_path_notification calls 'service.base_path' 2 times
Open

    @base_path = service.base_path
    @reply_to = service.account.support_email

    mail(:subject =>  "New ActiveDocs Path added: #{service.base_path}",
Severity: Minor
Found in app/models/api_docs/mailer.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

There are no issues that match your filters.

Category
Status