Sign upLogin

3scale/porta

View on GitHub
Star
app/models/session.rb

Summary

Maintainability
A
0 mins
Test Coverage

Session#username is a writable attribute
Open

  attr_accessor :username, :password, :remember_me
Severity: Minor
Found in app/models/session.rb by reek

A class that publishes a setter for an instance variable invites client classes to become too intimate with its inner workings, and in particular with its representation of state.

The same holds to a lesser extent for getters, but Reek doesn't flag those.

Example

Given:

class Klass
  attr_accessor :dummy
end

Reek would emit the following warning:

reek test.rb

test.rb -- 1 warning:
  [2]:Klass declares the writable attribute dummy (Attribute)

Session#password is a writable attribute
Open

  attr_accessor :username, :password, :remember_me
Severity: Minor
Found in app/models/session.rb by reek

A class that publishes a setter for an instance variable invites client classes to become too intimate with its inner workings, and in particular with its representation of state.

The same holds to a lesser extent for getters, but Reek doesn't flag those.

Example

Given:

class Klass
  attr_accessor :dummy
end

Reek would emit the following warning:

reek test.rb

test.rb -- 1 warning:
  [2]:Klass declares the writable attribute dummy (Attribute)

Session#remember_me is a writable attribute
Open

  attr_accessor :username, :password, :remember_me
Severity: Minor
Found in app/models/session.rb by reek

A class that publishes a setter for an instance variable invites client classes to become too intimate with its inner workings, and in particular with its representation of state.

The same holds to a lesser extent for getters, but Reek doesn't flag those.

Example

Given:

class Klass
  attr_accessor :dummy
end

Reek would emit the following warning:

reek test.rb

test.rb -- 1 warning:
  [2]:Klass declares the writable attribute dummy (Attribute)

There are no issues that match your filters.

Category
Status