Sign upLogin

3scale/porta

View on GitHub
Star
app/models/sso_authorization.rb

Summary

Maintainability
A
0 mins
Test Coverage

Mass assignment is not restricted using attr_accessible
Open

class SSOAuthorization < ApplicationRecord
Severity: Critical
Found in app/models/sso_authorization.rb by brakeman

This warning comes up if a model does not limit what attributes can be set through mass assignment.

In particular, this check looks for attr_accessible inside model definitions. If it is not found, this warning will be issued.

Brakeman also warns on use of attr_protected - especially since it was found to be vulnerable to bypass. Warnings for mass assignment on models using attr_protected will be reported, but at a lower confidence level.

Note that disabling mass assignment globally will suppress these warnings.

SSOAuthorization#self.find_or_build_as_used has 4 parameters
Open

  def self.find_or_build_as_used(user:, uid:, authentication_provider:, id_token: nil)
Severity: Minor
Found in app/models/sso_authorization.rb by reek

A Long Parameter List occurs when a method has a lot of parameters.

Example

Given

class Dummy
  def long_list(foo,bar,baz,fling,flung)
    puts foo,bar,baz,fling,flung
  end
end

Reek would report the following warning:

test.rb -- 1 warning:
  [2]:Dummy#long_list has 5 parameters (LongParameterList)

A common solution to this problem would be the introduction of parameter objects.

There are no issues that match your filters.

Category
Status