3scale/porta

View on GitHub
app/models/web_hook.rb

Summary

Maintainability
A
0 mins
Test Coverage

attr_accessible is recommended over attr_protected
Open

  attr_protected :account_id, :tenant_id
Severity: Minor
Found in app/models/web_hook.rb by brakeman

This warning comes up if a model does not limit what attributes can be set through mass assignment.

In particular, this check looks for attr_accessible inside model definitions. If it is not found, this warning will be issued.

Brakeman also warns on use of attr_protected - especially since it was found to be vulnerable to bypass. Warnings for mass assignment on models using attr_protected will be reported, but at a lower confidence level.

Note that disabling mass assignment globally will suppress these warnings.

WebHook#ping has the variable name 'e'
Open

  rescue => e
Severity: Minor
Found in app/models/web_hook.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

There are no issues that match your filters.

Category
Status