Sign upLogin

3scale/porta

View on GitHub
Star
app/observers/billing_observer.rb

Summary

Maintainability
A
0 mins
Test Coverage

BillingObserver#plan_changed calls 'now.end_of_month' 2 times
Open

      period = TimeRange.new(now, now.end_of_month)
      entitlements_options[:invoice] = strategy.bill_plan_change(contract, period).try(:invoice)
      contract.update_attribute :paid_until, now.end_of_month # TODO: move this line inside the billing strategy
Severity: Minor
Found in app/observers/billing_observer.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

There are no issues that match your filters.

Category
Status