app/presenters/provider/admin/accounts_show_presenter.rb
Provider::Admin::AccountsShowPresenter#redhat_customer_verification_enabled? calls 'ThreeScale.config' 2 times Open
Open
ThreeScale.config.redhat_customer_portal.enabled && !ThreeScale.config.onpremises
- Read upRead up
- Exclude checks
Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.
Reek implements a check for Duplicate Method Call.
Example
Here's a very much simplified and contrived example. The following method will report a warning:
def double_thing()
@other.thing + @other.thing
end
One quick approach to silence Reek would be to refactor the code thus:
def double_thing()
thing = @other.thing
thing + thing
end
A slightly different approach would be to replace all calls of double_thing
by calls to @other.double_thing
:
class Other
def double_thing()
thing + thing
end
end
The approach you take will depend on balancing other factors in your code.
Provider::Admin::AccountsShowPresenter#redhat_customer_verification_enabled? doesn't depend on instance state (maybe move it to another class?) Open
Open
def redhat_customer_verification_enabled?
- Read upRead up
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.