Sign upLogin

3scale/porta

View on GitHub
Star
app/queries/detailed_invoices_by_period_query.rb

Summary

Maintainability
A
0 mins
Test Coverage

DetailedInvoicesByPeriodQuery#each contains iterators nested 2 deep
Open

        invoice.line_items.find_each do |line_item|
Severity: Minor
Found in app/queries/detailed_invoices_by_period_query.rb by reek

A Nested Iterator occurs when a block contains another block.

Example

Given

class Duck
  class << self
    def duck_names
      %i!tick trick track!.each do |surname|
        %i!duck!.each do |last_name|
          puts "full name is #{surname} #{last_name}"
        end
      end
    end
  end
end

Reek would report the following warning:

test.rb -- 1 warning:
  [5]:Duck#duck_names contains iterators nested 2 deep (NestedIterators)

DetailedInvoicesByPeriodQuery#each calls 'invoice.line_items' 2 times
Open

      if invoice.line_items.none?
        yield invoice, LineItem.new
      else
        invoice.line_items.find_each do |line_item|
Severity: Minor
Found in app/queries/detailed_invoices_by_period_query.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

There are no issues that match your filters.

Category
Status