Sign upLogin

3scale/porta

View on GitHub
Star
app/queries/new_accounts_query.rb

Summary

Maintainability
A
0 mins
Test Coverage

NewAccountsQuery#oracle_subquery calls 'sift(:in_timezone, created_at, timezone_name)' 2 times
Open

      sift(:date, sift(:in_timezone, created_at, timezone_name)).in(range)
    end

    query = query.selecting do
      [
Severity: Minor
Found in app/queries/new_accounts_query.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

NewAccountsQuery#mysql_subquery calls 'sift(:in_timezone, created_at, timezone_name)' 2 times
Open

        .where.has { sift(:date, sift(:in_timezone, created_at, timezone_name)).in(range) }
        .grouping { sift(:date_format, sift(:in_timezone, created_at, timezone_name), date_format).to_sql }
Severity: Minor
Found in app/queries/new_accounts_query.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

NewAccountsQuery takes parameters ['date_format', 'range'] to 5 methods
Open

  def mysql_query(range, date_format)
    mysql_subquery(range, date_format)
  end

  def postgres_query(range, date_format)
Severity: Minor
Found in app/queries/new_accounts_query.rb by reek

In general, a Data Clump occurs when the same two or three items frequently appear together in classes and parameter lists, or when a group of instance variable names start or end with similar substrings.

The recurrence of the items often means there is duplicate code spread around to handle them. There may be an abstraction missing from the code, making the system harder to understand.

Example

Given

class Dummy
  def x(y1,y2); end
  def y(y1,y2); end
  def z(y1,y2); end
end

Reek would emit the following warning:

test.rb -- 1 warning:
  [2, 3, 4]:Dummy takes parameters [y1, y2] to 3 methods (DataClump)

A possible way to fix this problem (quoting from Martin Fowler):

The first step is to replace data clumps with objects and use the objects whenever you see them. An immediate benefit is that you'll shrink some parameter lists. The interesting stuff happens as you begin to look for behavior to move into the new objects.

There are no issues that match your filters.

Category
Status