Sign upLogin

3scale/porta

View on GitHub
Star
app/queries/usage_limit_violations_query.rb

Summary

Maintainability
A
0 mins
Test Coverage

UsageLimitViolationsQuery#usage_limit_violations calls 'count(id)' 2 times
Open

        .ordering { count(id).desc }
        .selecting do
      [ user_account.id.as('account_id'),
        user_account.org_name.as('account_name'),
        count(id).as('alerts_count') ]
Severity: Minor
Found in app/queries/usage_limit_violations_query.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

UsageLimitViolationsQuery#usage_limit_violations calls 'user_account.org_name' 2 times
Open

        .grouping { [user_account.id, user_account.org_name ] }
        .ordering { count(id).desc }
        .selecting do
      [ user_account.id.as('account_id'),
        user_account.org_name.as('account_name'),
Severity: Minor
Found in app/queries/usage_limit_violations_query.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

UsageLimitViolationsQuery#usage_limit_violations calls 'user_account.id' 2 times
Open

        .grouping { [user_account.id, user_account.org_name ] }
        .ordering { count(id).desc }
        .selecting do
      [ user_account.id.as('account_id'),
Severity: Minor
Found in app/queries/usage_limit_violations_query.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

UsageLimitViolationsQuery::AlertConversion#convert_alert doesn't depend on instance state (maybe move it to another class?)
Open

    def convert_alert(alert)
Severity: Minor
Found in app/queries/usage_limit_violations_query.rb by reek

A Utility Function is any instance method that has no dependency on the state of the instance.

UsageLimitViolationsQuery::UsageLimitViolation#account has the variable name 'a'
Open

      ::Account.new { |a| a.assign_attributes(account_attributes, without_protection: true) }
Severity: Minor
Found in app/queries/usage_limit_violations_query.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

There are no issues that match your filters.

Category
Status