app/workers/persist_event_worker.rb
PersistEventWorker#perform doesn't depend on instance state (maybe move it to another class?) Open
Open
def perform(event_attrs)
- Read upRead up
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.
PersistEventWorker#perform has the variable name 'e' Open
Open
rescue ActiveRecord::RecordNotUnique => e
- Read upRead up
- Exclude checks
An Uncommunicative Variable Name
is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.