3scale/porta

View on GitHub
app/workers/service_discovery/create_service_worker.rb

Summary

Maintainability
A
0 mins
Test Coverage

ServiceDiscovery::CreateServiceWorker#perform has 4 parameters
Open

    def perform(account_id, cluster_namespace, cluster_service_name, user_id=nil)

A Long Parameter List occurs when a method has a lot of parameters.

Example

Given

class Dummy
  def long_list(foo,bar,baz,fling,flung)
    puts foo,bar,baz,fling,flung
  end
end

Reek would report the following warning:

test.rb -- 1 warning:
  [2]:Dummy#long_list has 5 parameters (LongParameterList)

A common solution to this problem would be the introduction of parameter objects.

ServiceDiscovery::CreateServiceWorker#perform doesn't depend on instance state (maybe move it to another class?)
Invalid

    def perform(account_id, cluster_namespace, cluster_service_name, user_id=nil)

A Utility Function is any instance method that has no dependency on the state of the instance.

There are no issues that match your filters.

Category
Status