3scale/porta

View on GitHub
config/initializers/protected_attributes_hacks.rb

Summary

Maintainability
A
0 mins
Test Coverage

ProtectedAttributesHacks::QueryMethods#sanitize_forbidden_attributes manually dispatches method call
Open

        super(attributes.respond_to?(:permit!) ? attributes.dup.permit! : attributes)

Reek reports a Manual Dispatch smell if it finds source code that manually checks whether an object responds to a method before that method is called. Manual dispatch is a type of Simulated Polymorphism which leads to code that is harder to reason about, debug, and refactor.

Example

class MyManualDispatcher
  attr_reader :foo

  def initialize(foo)
    @foo = foo
  end

  def call
    foo.bar if foo.respond_to?(:bar)
  end
end

Reek would emit the following warning:

test.rb -- 1 warning:
  [9]: MyManualDispatcher manually dispatches method call (ManualDispatch)

There are no issues that match your filters.

Category
Status