Sign upLogin

3scale/porta

View on GitHub
Star
db/migrate/20090206174052_create_settings_object_for_accounts.rb

Summary

Maintainability
A
0 mins
Test Coverage

CreateSettingsObjectForAccounts#self.up performs a nil-check
Open

      Settings.create(:account_id => a.id) unless !a.settings.nil?
Severity: Minor
Found in db/migrate/20090206174052_create_settings_object_for_accounts.rb by reek

A NilCheck is a type check. Failures of NilCheck violate the "tell, don't ask" principle.

Additionally, type checks often mask bigger problems in your source code like not using OOP and / or polymorphism when you should.

Example

Given

class Klass
  def nil_checker(argument)
    if argument.nil?
      puts "argument isn't nil!"
    end
  end
end

Reek would emit the following warning:

test.rb -- 1 warning:
  [3]:Klass#nil_checker performs a nil-check. (NilCheck)

CreateSettingsObjectForAccounts#self.up has the variable name 'a'
Open

    Account.with_deleted.all.each do |a|
Severity: Minor
Found in db/migrate/20090206174052_create_settings_object_for_accounts.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

There are no issues that match your filters.

Category
Status