Sign upLogin

3scale/porta

View on GitHub
Star
db/migrate/20100122173112_move_superadmin_over_to_master_account.rb

Summary

Maintainability
A
0 mins
Test Coverage

MoveSuperadminOverToMasterAccount#self.up calls 'superadmin['account_id']' 4 times
Open

      if superadmin['account_id'].to_i != master_id.to_i
        execute(%(DELETE FROM accounts WHERE id = #{superadmin['account_id']}))
        execute(%(DELETE FROM profiles WHERE account_id = #{superadmin['account_id']}))
        execute(%(DELETE FROM services WHERE account_id = #{superadmin['account_id']}))
Severity: Minor
Found in db/migrate/20100122173112_move_superadmin_over_to_master_account.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

There are no issues that match your filters.

Category
Status