Sign upLogin

3scale/porta

View on GitHub
Star
db/migrate/20100216120713_cms_streams.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method up has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.up
    create_table :streams do |t|
      t.string :name
      t.string :slug
      t.belongs_to :attachment
Severity: Minor
Found in db/migrate/20100216120713_cms_streams.rb - About 1 hr to fix

    CmsStreams#self.up has approx 33 statements
    Open

      def self.up
    Severity: Minor
    Found in db/migrate/20100216120713_cms_streams.rb by reek

    A method with Too Many Statements is any method that has a large number of lines.

    Too Many Statements warns about any method that has more than 5 statements. Reek's smell detector for Too Many Statements counts +1 for every simple statement in a method and +1 for every statement within a control structure (if, else, case, when, for, while, until, begin, rescue) but it doesn't count the control structure itself.

    So the following method would score +6 in Reek's statement-counting algorithm:

    def parse(arg, argv, &error)
  if !(val = arg) and (argv.empty? or /\A-/ =~ (val = argv[0]))
    return nil, block, nil                                         # +1
  end
  opt = (val = parse_arg(val, &error))[1]                          # +2
  val = conv_arg(*val)                                             # +3
  if opt and !arg
    argv.shift                                                     # +4
  else
    val[0] = nil                                                   # +5
  end
  val                                                              # +6
end

    (You might argue that the two assigments within the first @if@ should count as statements, and that perhaps the nested assignment should count as +2.)

    CmsStreams#self.up calls 't.integer :version' 2 times
    Open

          t.integer :version
      t.integer :lock_version, :default => 0
      t.boolean :published, :default => false
      t.boolean :deleted, :default => false
      t.boolean :archived, :default => false
    Severity: Minor
    Found in db/migrate/20100216120713_cms_streams.rb by reek

    Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

    Reek implements a check for Duplicate Method Call.

    Example

    Here's a very much simplified and contrived example. The following method will report a warning:

    def double_thing()
  @other.thing + @other.thing
end

    One quick approach to silence Reek would be to refactor the code thus:

    def double_thing()
  thing = @other.thing
  thing + thing
end

    A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

    class Other
  def double_thing()
    thing + thing
  end
end

    The approach you take will depend on balancing other factors in your code.

    CmsStreams#self.up calls 't.belongs_to :category' 2 times
    Open

          t.belongs_to :category
      t.belongs_to :tag
      t.integer :version
      t.integer :lock_version, :default => 0
      t.boolean :published, :default => false
    Severity: Minor
    Found in db/migrate/20100216120713_cms_streams.rb by reek

    Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

    Reek implements a check for Duplicate Method Call.

    Example

    Here's a very much simplified and contrived example. The following method will report a warning:

    def double_thing()
  @other.thing + @other.thing
end

    One quick approach to silence Reek would be to refactor the code thus:

    def double_thing()
  thing = @other.thing
  thing + thing
end

    A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

    class Other
  def double_thing()
    thing + thing
  end
end

    The approach you take will depend on balancing other factors in your code.

    CmsStreams#self.up calls '64.kilobytes + 1' 2 times
    Open

          t.text :body, :size => (64.kilobytes + 1)
      t.belongs_to :category
      t.belongs_to :tag
      t.integer :version
      t.integer :lock_version, :default => 0
    Severity: Minor
    Found in db/migrate/20100216120713_cms_streams.rb by reek

    Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

    Reek implements a check for Duplicate Method Call.

    Example

    Here's a very much simplified and contrived example. The following method will report a warning:

    def double_thing()
  @other.thing + @other.thing
end

    One quick approach to silence Reek would be to refactor the code thus:

    def double_thing()
  thing = @other.thing
  thing + thing
end

    A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

    class Other
  def double_thing()
    thing + thing
  end
end

    The approach you take will depend on balancing other factors in your code.

    CmsStreams#self.up calls 't.integer :created_by_id' 2 times
    Open

          t.integer :created_by_id
      t.integer :updated_by_id
      t.timestamps
    end
    create_table :stream_versions do |t|
    Severity: Minor
    Found in db/migrate/20100216120713_cms_streams.rb by reek

    Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

    Reek implements a check for Duplicate Method Call.

    Example

    Here's a very much simplified and contrived example. The following method will report a warning:

    def double_thing()
  @other.thing + @other.thing
end

    One quick approach to silence Reek would be to refactor the code thus:

    def double_thing()
  thing = @other.thing
  thing + thing
end

    A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

    class Other
  def double_thing()
    thing + thing
  end
end

    The approach you take will depend on balancing other factors in your code.

    CmsStreams#self.up calls '64.kilobytes' 2 times
    Open

          t.text :body, :size => (64.kilobytes + 1)
      t.belongs_to :category
      t.belongs_to :tag
      t.integer :version
      t.integer :lock_version, :default => 0
    Severity: Minor
    Found in db/migrate/20100216120713_cms_streams.rb by reek

    Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

    Reek implements a check for Duplicate Method Call.

    Example

    Here's a very much simplified and contrived example. The following method will report a warning:

    def double_thing()
  @other.thing + @other.thing
end

    One quick approach to silence Reek would be to refactor the code thus:

    def double_thing()
  thing = @other.thing
  thing + thing
end

    A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

    class Other
  def double_thing()
    thing + thing
  end
end

    The approach you take will depend on balancing other factors in your code.

    CmsStreams#self.up calls 't.integer :attachment_version' 2 times
    Open

          t.integer :attachment_version
      t.text :body, :size => (64.kilobytes + 1)
      t.belongs_to :category
      t.belongs_to :tag
      t.integer :version
    Severity: Minor
    Found in db/migrate/20100216120713_cms_streams.rb by reek

    Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

    Reek implements a check for Duplicate Method Call.

    Example

    Here's a very much simplified and contrived example. The following method will report a warning:

    def double_thing()
  @other.thing + @other.thing
end

    One quick approach to silence Reek would be to refactor the code thus:

    def double_thing()
  thing = @other.thing
  thing + thing
end

    A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

    class Other
  def double_thing()
    thing + thing
  end
end

    The approach you take will depend on balancing other factors in your code.

    CmsStreams#self.up calls 't.boolean :deleted, :default => false' 2 times
    Open

          t.boolean :deleted, :default => false
      t.boolean :archived, :default => false
      t.integer :created_by_id
      t.integer :updated_by_id
      t.timestamps
    Severity: Minor
    Found in db/migrate/20100216120713_cms_streams.rb by reek

    Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

    Reek implements a check for Duplicate Method Call.

    Example

    Here's a very much simplified and contrived example. The following method will report a warning:

    def double_thing()
  @other.thing + @other.thing
end

    One quick approach to silence Reek would be to refactor the code thus:

    def double_thing()
  thing = @other.thing
  thing + thing
end

    A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

    class Other
  def double_thing()
    thing + thing
  end
end

    The approach you take will depend on balancing other factors in your code.

    CmsStreams#self.up calls 't.text :body, :size => (64.kilobytes + 1)' 2 times
    Open

          t.text :body, :size => (64.kilobytes + 1)
      t.belongs_to :category
      t.belongs_to :tag
      t.integer :version
      t.integer :lock_version, :default => 0
    Severity: Minor
    Found in db/migrate/20100216120713_cms_streams.rb by reek

    Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

    Reek implements a check for Duplicate Method Call.

    Example

    Here's a very much simplified and contrived example. The following method will report a warning:

    def double_thing()
  @other.thing + @other.thing
end

    One quick approach to silence Reek would be to refactor the code thus:

    def double_thing()
  thing = @other.thing
  thing + thing
end

    A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

    class Other
  def double_thing()
    thing + thing
  end
end

    The approach you take will depend on balancing other factors in your code.

    CmsStreams#self.up calls 't.belongs_to :tag' 2 times
    Open

          t.belongs_to :tag
      t.integer :version
      t.integer :lock_version, :default => 0
      t.boolean :published, :default => false
      t.boolean :deleted, :default => false
    Severity: Minor
    Found in db/migrate/20100216120713_cms_streams.rb by reek

    Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

    Reek implements a check for Duplicate Method Call.

    Example

    Here's a very much simplified and contrived example. The following method will report a warning:

    def double_thing()
  @other.thing + @other.thing
end

    One quick approach to silence Reek would be to refactor the code thus:

    def double_thing()
  thing = @other.thing
  thing + thing
end

    A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

    class Other
  def double_thing()
    thing + thing
  end
end

    The approach you take will depend on balancing other factors in your code.

    CmsStreams#self.up calls 't.belongs_to :attachment' 2 times
    Open

          t.belongs_to :attachment
      t.integer :attachment_version
      t.text :body, :size => (64.kilobytes + 1)
      t.belongs_to :category
      t.belongs_to :tag
    Severity: Minor
    Found in db/migrate/20100216120713_cms_streams.rb by reek

    Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

    Reek implements a check for Duplicate Method Call.

    Example

    Here's a very much simplified and contrived example. The following method will report a warning:

    def double_thing()
  @other.thing + @other.thing
end

    One quick approach to silence Reek would be to refactor the code thus:

    def double_thing()
  thing = @other.thing
  thing + thing
end

    A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

    class Other
  def double_thing()
    thing + thing
  end
end

    The approach you take will depend on balancing other factors in your code.

    CmsStreams#self.up calls 't.boolean :archived, :default => false' 2 times
    Open

          t.boolean :archived, :default => false
      t.integer :created_by_id
      t.integer :updated_by_id
      t.timestamps
    end
    Severity: Minor
    Found in db/migrate/20100216120713_cms_streams.rb by reek

    Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

    Reek implements a check for Duplicate Method Call.

    Example

    Here's a very much simplified and contrived example. The following method will report a warning:

    def double_thing()
  @other.thing + @other.thing
end

    One quick approach to silence Reek would be to refactor the code thus:

    def double_thing()
  thing = @other.thing
  thing + thing
end

    A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

    class Other
  def double_thing()
    thing + thing
  end
end

    The approach you take will depend on balancing other factors in your code.

    CmsStreams#self.up calls 't.boolean :published, :default => false' 2 times
    Open

          t.boolean :published, :default => false
      t.boolean :deleted, :default => false
      t.boolean :archived, :default => false
      t.integer :created_by_id
      t.integer :updated_by_id
    Severity: Minor
    Found in db/migrate/20100216120713_cms_streams.rb by reek

    Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

    Reek implements a check for Duplicate Method Call.

    Example

    Here's a very much simplified and contrived example. The following method will report a warning:

    def double_thing()
  @other.thing + @other.thing
end

    One quick approach to silence Reek would be to refactor the code thus:

    def double_thing()
  thing = @other.thing
  thing + thing
end

    A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

    class Other
  def double_thing()
    thing + thing
  end
end

    The approach you take will depend on balancing other factors in your code.

    CmsStreams#self.up calls 't.integer :updated_by_id' 2 times
    Open

          t.integer :updated_by_id
      t.timestamps
    end
    create_table :stream_versions do |t|
      t.integer :stream_id
    Severity: Minor
    Found in db/migrate/20100216120713_cms_streams.rb by reek

    Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

    Reek implements a check for Duplicate Method Call.

    Example

    Here's a very much simplified and contrived example. The following method will report a warning:

    def double_thing()
  @other.thing + @other.thing
end

    One quick approach to silence Reek would be to refactor the code thus:

    def double_thing()
  thing = @other.thing
  thing + thing
end

    A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

    class Other
  def double_thing()
    thing + thing
  end
end

    The approach you take will depend on balancing other factors in your code.

    CmsStreams#self.up calls 't.string :name' 2 times
    Open

          t.string :name
      t.string :slug
      t.belongs_to :attachment
      t.integer :attachment_version
      t.text :body, :size => (64.kilobytes + 1)
    Severity: Minor
    Found in db/migrate/20100216120713_cms_streams.rb by reek

    Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

    Reek implements a check for Duplicate Method Call.

    Example

    Here's a very much simplified and contrived example. The following method will report a warning:

    def double_thing()
  @other.thing + @other.thing
end

    One quick approach to silence Reek would be to refactor the code thus:

    def double_thing()
  thing = @other.thing
  thing + thing
end

    A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

    class Other
  def double_thing()
    thing + thing
  end
end

    The approach you take will depend on balancing other factors in your code.

    CmsStreams#self.up calls 't.string :slug' 2 times
    Open

          t.string :slug
      t.belongs_to :attachment
      t.integer :attachment_version
      t.text :body, :size => (64.kilobytes + 1)
      t.belongs_to :category
    Severity: Minor
    Found in db/migrate/20100216120713_cms_streams.rb by reek

    Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

    Reek implements a check for Duplicate Method Call.

    Example

    Here's a very much simplified and contrived example. The following method will report a warning:

    def double_thing()
  @other.thing + @other.thing
end

    One quick approach to silence Reek would be to refactor the code thus:

    def double_thing()
  thing = @other.thing
  thing + thing
end

    A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

    class Other
  def double_thing()
    thing + thing
  end
end

    The approach you take will depend on balancing other factors in your code.

    CmsStreams#self.up calls 't.timestamps' 2 times
    Open

          t.timestamps
    end
    create_table :stream_versions do |t|
      t.integer :stream_id
      t.string :name
    Severity: Minor
    Found in db/migrate/20100216120713_cms_streams.rb by reek

    Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

    Reek implements a check for Duplicate Method Call.

    Example

    Here's a very much simplified and contrived example. The following method will report a warning:

    def double_thing()
  @other.thing + @other.thing
end

    One quick approach to silence Reek would be to refactor the code thus:

    def double_thing()
  thing = @other.thing
  thing + thing
end

    A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

    class Other
  def double_thing()
    thing + thing
  end
end

    The approach you take will depend on balancing other factors in your code.

    CmsStreams#self.up has the variable name 't'
    Open

        create_table :streams do |t|
      t.string :name
      t.string :slug
      t.belongs_to :attachment
      t.integer :attachment_version
    Severity: Minor
    Found in db/migrate/20100216120713_cms_streams.rb by reek

    An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

    Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

    There are no issues that match your filters.

    Category
    Status