Sign upLogin

3scale/porta

View on GitHub
Star
db/migrate/20110301170124_create_account_and_service_plans.rb

Summary

Maintainability
A
0 mins
Test Coverage

CreateAccountAndServicePlans#self.up has approx 12 statements
Open

  def self.up
Severity: Minor
Found in db/migrate/20110301170124_create_account_and_service_plans.rb by reek

A method with Too Many Statements is any method that has a large number of lines.

Too Many Statements warns about any method that has more than 5 statements. Reek's smell detector for Too Many Statements counts +1 for every simple statement in a method and +1 for every statement within a control structure (if, else, case, when, for, while, until, begin, rescue) but it doesn't count the control structure itself.

So the following method would score +6 in Reek's statement-counting algorithm:

def parse(arg, argv, &error)
  if !(val = arg) and (argv.empty? or /\A-/ =~ (val = argv[0]))
    return nil, block, nil                                         # +1
  end
  opt = (val = parse_arg(val, &error))[1]                          # +2
  val = conv_arg(*val)                                             # +3
  if opt and !arg
    argv.shift                                                     # +4
  else
    val[0] = nil                                                   # +5
  end
  val                                                              # +6
end

(You might argue that the two assigments within the first @if@ should count as statements, and that perhaps the nested assignment should count as +2.)

CreateAccountAndServicePlans#self.buy_plans has approx 10 statements
Open

  def self.buy_plans(buyer)
Severity: Minor
Found in db/migrate/20110301170124_create_account_and_service_plans.rb by reek

A method with Too Many Statements is any method that has a large number of lines.

Too Many Statements warns about any method that has more than 5 statements. Reek's smell detector for Too Many Statements counts +1 for every simple statement in a method and +1 for every statement within a control structure (if, else, case, when, for, while, until, begin, rescue) but it doesn't count the control structure itself.

So the following method would score +6 in Reek's statement-counting algorithm:

def parse(arg, argv, &error)
  if !(val = arg) and (argv.empty? or /\A-/ =~ (val = argv[0]))
    return nil, block, nil                                         # +1
  end
  opt = (val = parse_arg(val, &error))[1]                          # +2
  val = conv_arg(*val)                                             # +3
  if opt and !arg
    argv.shift                                                     # +4
  else
    val[0] = nil                                                   # +5
  end
  val                                                              # +6
end

(You might argue that the two assigments within the first @if@ should count as statements, and that perhaps the nested assignment should count as +2.)

CreateAccountAndServicePlans#self.up calls 'Account.module_eval' 2 times
Open

    Account.module_eval do
      def service_preffix
        Configuration.configuration["service_preffix"]
      end
    end
Severity: Minor
Found in db/migrate/20110301170124_create_account_and_service_plans.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

CreateAccountAndServicePlans#self.add_plans_to_provider calls 'provider.services' 3 times
Open

      if provider.services.empty?
        provider.send(:create_default_service)
      end

      service_plan = provider.services.first.service_plans.create!( :name => 'Default', :issuer => provider.services.first, :master => true)
Severity: Minor
Found in db/migrate/20110301170124_create_account_and_service_plans.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

CreateAccountAndServicePlans#self.buy_plans calls 'buyer.buy!(plan)' 2 times
Open

        buyer.buy!(plan)
        puts "- bought account plan #{plan.name}"

        plan = provider.services.first.service_plans.detect{|p| p.master}
        buyer.buy!(plan)
Severity: Minor
Found in db/migrate/20110301170124_create_account_and_service_plans.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

CreateAccountAndServicePlans#self.buy_plans calls 'p.master' 2 times
Open

        plan = provider.account_plans.detect{|p| p.master}
        buyer.buy!(plan)
        puts "- bought account plan #{plan.name}"

        plan = provider.services.first.service_plans.detect{|p| p.master}
Severity: Minor
Found in db/migrate/20110301170124_create_account_and_service_plans.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

CreateAccountAndServicePlans#self.buy_plans calls 'plan.name' 2 times
Open

        puts "- bought account plan #{plan.name}"

        plan = provider.services.first.service_plans.detect{|p| p.master}
        buyer.buy!(plan)
        puts "- bought service plan #{plan.name}"
Severity: Minor
Found in db/migrate/20110301170124_create_account_and_service_plans.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

CreateAccountAndServicePlans#self.add_plans_to_provider calls 'provider.services.first' 2 times
Open

      service_plan = provider.services.first.service_plans.create!( :name => 'Default', :issuer => provider.services.first, :master => true)
Severity: Minor
Found in db/migrate/20110301170124_create_account_and_service_plans.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

CreateAccountAndServicePlans#self.buy_plans has the variable name 'p'
Open

        plan = provider.account_plans.detect{|p| p.master}
        buyer.buy!(plan)
        puts "- bought account plan #{plan.name}"

        plan = provider.services.first.service_plans.detect{|p| p.master}
Severity: Minor
Found in db/migrate/20110301170124_create_account_and_service_plans.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

CreateAccountAndServicePlans#self.up has the variable name 'p'
Open

    Account.providers.find_each { |p| add_plans_to_provider(p) }
Severity: Minor
Found in db/migrate/20110301170124_create_account_and_service_plans.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

There are no issues that match your filters.

Category
Status