Sign upLogin

3scale/porta

View on GitHub
Star
db/migrate/20110404133322_seed_configuration_values.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method up has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.up
    Configuration::Value.delete_all

    Account.module_eval do
      def service_preffix
Severity: Minor
Found in db/migrate/20110404133322_seed_configuration_values.rb - About 1 hr to fix

    Method up has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.up
    Configuration::Value.delete_all

    Account.module_eval do
      def service_preffix
    Severity: Minor
    Found in db/migrate/20110404133322_seed_configuration_values.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    SeedConfigurationValues#self.down has approx 10 statements
    Open

      def self.down
    Severity: Minor
    Found in db/migrate/20110404133322_seed_configuration_values.rb by reek

    A method with Too Many Statements is any method that has a large number of lines.

    Too Many Statements warns about any method that has more than 5 statements. Reek's smell detector for Too Many Statements counts +1 for every simple statement in a method and +1 for every statement within a control structure (if, else, case, when, for, while, until, begin, rescue) but it doesn't count the control structure itself.

    So the following method would score +6 in Reek's statement-counting algorithm:

    def parse(arg, argv, &error)
  if !(val = arg) and (argv.empty? or /\A-/ =~ (val = argv[0]))
    return nil, block, nil                                         # +1
  end
  opt = (val = parse_arg(val, &error))[1]                          # +2
  val = conv_arg(*val)                                             # +3
  if opt and !arg
    argv.shift                                                     # +4
  else
    val[0] = nil                                                   # +5
  end
  val                                                              # +6
end

    (You might argue that the two assigments within the first @if@ should count as statements, and that perhaps the nested assignment should count as +2.)

    SeedConfigurationValues#self.up has approx 14 statements
    Open

      def self.up
    Severity: Minor
    Found in db/migrate/20110404133322_seed_configuration_values.rb by reek

    A method with Too Many Statements is any method that has a large number of lines.

    Too Many Statements warns about any method that has more than 5 statements. Reek's smell detector for Too Many Statements counts +1 for every simple statement in a method and +1 for every statement within a control structure (if, else, case, when, for, while, until, begin, rescue) but it doesn't count the control structure itself.

    So the following method would score +6 in Reek's statement-counting algorithm:

    def parse(arg, argv, &error)
  if !(val = arg) and (argv.empty? or /\A-/ =~ (val = argv[0]))
    return nil, block, nil                                         # +1
  end
  opt = (val = parse_arg(val, &error))[1]                          # +2
  val = conv_arg(*val)                                             # +3
  if opt and !arg
    argv.shift                                                     # +4
  else
    val[0] = nil                                                   # +5
  end
  val                                                              # +6
end

    (You might argue that the two assigments within the first @if@ should count as statements, and that perhaps the nested assignment should count as +2.)

    SeedConfigurationValues#self.up calls 'account.settings.authentication_strategy' 2 times
    Open

          if account.settings.authentication_strategy != :internal
        account.config[:authentication_strategy] = account.settings.authentication_strategy
    Severity: Minor
    Found in db/migrate/20110404133322_seed_configuration_values.rb by reek

    Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

    Reek implements a check for Duplicate Method Call.

    Example

    Here's a very much simplified and contrived example. The following method will report a warning:

    def double_thing()
  @other.thing + @other.thing
end

    One quick approach to silence Reek would be to refactor the code thus:

    def double_thing()
  thing = @other.thing
  thing + thing
end

    A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

    class Other
  def double_thing()
    thing + thing
  end
end

    The approach you take will depend on balancing other factors in your code.

    SeedConfigurationValues#self.up calls 'Account.module_eval' 2 times
    Open

        Account.module_eval do
      def service_preffix
        Configuration.configuration["service_preffix"]
      end
    end
    Severity: Minor
    Found in db/migrate/20110404133322_seed_configuration_values.rb by reek

    Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

    Reek implements a check for Duplicate Method Call.

    Example

    Here's a very much simplified and contrived example. The following method will report a warning:

    def double_thing()
  @other.thing + @other.thing
end

    One quick approach to silence Reek would be to refactor the code thus:

    def double_thing()
  thing = @other.thing
  thing + thing
end

    A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

    class Other
  def double_thing()
    thing + thing
  end
end

    The approach you take will depend on balancing other factors in your code.

    SeedConfigurationValues#self.up calls 'account.config' 6 times
    Open

          account.config.class_eval do
        def []=(name, value)
          values[name] = self.class.parse(value)
        end
      end
    Severity: Minor
    Found in db/migrate/20110404133322_seed_configuration_values.rb by reek

    Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

    Reek implements a check for Duplicate Method Call.

    Example

    Here's a very much simplified and contrived example. The following method will report a warning:

    def double_thing()
  @other.thing + @other.thing
end

    One quick approach to silence Reek would be to refactor the code thus:

    def double_thing()
  thing = @other.thing
  thing + thing
end

    A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

    class Other
  def double_thing()
    thing + thing
  end
end

    The approach you take will depend on balancing other factors in your code.

    SeedConfigurationValues#self.up calls 'account.settings' 2 times
    Open

          if account.settings.authentication_strategy != :internal
        account.config[:authentication_strategy] = account.settings.authentication_strategy
    Severity: Minor
    Found in db/migrate/20110404133322_seed_configuration_values.rb by reek

    Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

    Reek implements a check for Duplicate Method Call.

    Example

    Here's a very much simplified and contrived example. The following method will report a warning:

    def double_thing()
  @other.thing + @other.thing
end

    One quick approach to silence Reek would be to refactor the code thus:

    def double_thing()
  thing = @other.thing
  thing + thing
end

    A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

    class Other
  def double_thing()
    thing + thing
  end
end

    The approach you take will depend on balancing other factors in your code.

    SeedConfigurationValues#self.down calls 'account.config' 6 times
    Open

          account.multiple_cinstances_allowed = account.config[:multiple_applications]
      account.config.delete(:multiple_applications)

      account.backend_v2 = (account.backend_version == "2")
      account.config.delete(:backend_version)
    Severity: Minor
    Found in db/migrate/20110404133322_seed_configuration_values.rb by reek

    Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

    Reek implements a check for Duplicate Method Call.

    Example

    Here's a very much simplified and contrived example. The following method will report a warning:

    def double_thing()
  @other.thing + @other.thing
end

    One quick approach to silence Reek would be to refactor the code thus:

    def double_thing()
  thing = @other.thing
  thing + thing
end

    A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

    class Other
  def double_thing()
    thing + thing
  end
end

    The approach you take will depend on balancing other factors in your code.

    There are no issues that match your filters.

    Category
    Status