Sign upLogin

3scale/porta

View on GitHub
Star
db/migrate/20120109161319_add_tenant_id_to_bcms_tables.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method up has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.up
    add_column :account_group_memberships, :tenant_id, :integer
    add_column :attachment_versions, :tenant_id, :integer
    add_column :attachments, :tenant_id, :integer
    add_column :blog_comment_versions, :tenant_id, :integer
Severity: Minor
Found in db/migrate/20120109161319_add_tenant_id_to_bcms_tables.rb - About 1 hr to fix

    Method down has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.down
    remove_column :account_group_memberships, :tenant_id
    remove_column :attachment_versions, :tenant_id
    remove_column :attachments, :tenant_id
    remove_column :blog_comment_versions, :tenant_id
    Severity: Minor
    Found in db/migrate/20120109161319_add_tenant_id_to_bcms_tables.rb - About 1 hr to fix

      AddTenantIdToBcmsTables#self.down has approx 37 statements
      Open

        def self.down
      Severity: Minor
      Found in db/migrate/20120109161319_add_tenant_id_to_bcms_tables.rb by reek

      A method with Too Many Statements is any method that has a large number of lines.

      Too Many Statements warns about any method that has more than 5 statements. Reek's smell detector for Too Many Statements counts +1 for every simple statement in a method and +1 for every statement within a control structure (if, else, case, when, for, while, until, begin, rescue) but it doesn't count the control structure itself.

      So the following method would score +6 in Reek's statement-counting algorithm:

      def parse(arg, argv, &error)
  if !(val = arg) and (argv.empty? or /\A-/ =~ (val = argv[0]))
    return nil, block, nil                                         # +1
  end
  opt = (val = parse_arg(val, &error))[1]                          # +2
  val = conv_arg(*val)                                             # +3
  if opt and !arg
    argv.shift                                                     # +4
  else
    val[0] = nil                                                   # +5
  end
  val                                                              # +6
end

      (You might argue that the two assigments within the first @if@ should count as statements, and that perhaps the nested assignment should count as +2.)

      AddTenantIdToBcmsTables#self.up has approx 37 statements
      Open

        def self.up
      Severity: Minor
      Found in db/migrate/20120109161319_add_tenant_id_to_bcms_tables.rb by reek

      A method with Too Many Statements is any method that has a large number of lines.

      Too Many Statements warns about any method that has more than 5 statements. Reek's smell detector for Too Many Statements counts +1 for every simple statement in a method and +1 for every statement within a control structure (if, else, case, when, for, while, until, begin, rescue) but it doesn't count the control structure itself.

      So the following method would score +6 in Reek's statement-counting algorithm:

      def parse(arg, argv, &error)
  if !(val = arg) and (argv.empty? or /\A-/ =~ (val = argv[0]))
    return nil, block, nil                                         # +1
  end
  opt = (val = parse_arg(val, &error))[1]                          # +2
  val = conv_arg(*val)                                             # +3
  if opt and !arg
    argv.shift                                                     # +4
  else
    val[0] = nil                                                   # +5
  end
  val                                                              # +6
end

      (You might argue that the two assigments within the first @if@ should count as statements, and that perhaps the nested assignment should count as +2.)

      There are no issues that match your filters.

      Category
      Status